From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27714 invoked by alias); 3 Sep 2010 18:17:18 -0000 Received: (qmail 27689 invoked by uid 22791); 3 Sep 2010 18:17:14 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout20.012.net.il (HELO mtaout20.012.net.il) (80.179.55.166) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 03 Sep 2010 18:17:07 +0000 Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0L8600700NLJZO00@a-mtaout20.012.net.il> for gdb-patches@sourceware.org; Fri, 03 Sep 2010 21:16:38 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.202.93]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L86008DPO3O0I10@a-mtaout20.012.net.il>; Fri, 03 Sep 2010 21:16:38 +0300 (IDT) Date: Fri, 03 Sep 2010 22:07:00 -0000 From: Eli Zaretskii Subject: Re: [patch] gdb-add-index tweaks In-reply-to: <20100903180117.42E9D841F7@ruffy.mtv.corp.google.com> To: dje@google.com (Doug Evans) Cc: tromey@redhat.com, gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83hbi6ite0.fsf@gnu.org> References: <20100903180117.42E9D841F7@ruffy.mtv.corp.google.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-09/txt/msg00135.txt.bz2 > Date: Fri, 3 Sep 2010 11:01:17 -0700 (PDT) > From: dje@google.com (Doug Evans) > > This patch makes gdb-add-index.sh a (teensy) bit more robust > and restores the Makefile.in/gdb.texinfo changes (the latter with > a few tweaks). Thanks. > @@ -15230,8 +15230,8 @@ This computation does not apply to the ` > When @value{GDBN} finds a symbol file, it scans the symbols in the > file in order to construct an internal symbol table. This lets most > @value{GDBN} operations work quickly---at the cost of a delay early > -on. For large programs, this delay can be quite lengthy, so > -@value{GDBN} provides a way to build an index, which speeds up > +on. For large programs this delay can be quite lengthy, so > +@value{GDBN} provides a way to build an index which speeds up > startup. I see no reason for this hunk of changes. There's nothing wrong with the original text. > There are currently some limitation on indices. They only work when > -for DWARF debugging information, not stabs. And, they do not > -currently work for programs using Ada. > +using DWARF debugging information, not stabs. And, they do not > +currently work for programs written in Ada. This is okay, but I would lose the "not stabs" part, because we support more than just DWARF and stabs. I understand that only DWARF will enable this feature. > +@value{GDBN} comes with a program, @command{gdb-add-index}, which can > +be used to add the index to a symbol file. It takes the symbol file > +as its only argument: We don't really explain what is a "symbol file". But I guess this is a problem with this entire chapter; feel free to fix that or leave it as it is now. > +@command{gdb-add-index} is a simple script, with minimal error checking. If it's a script, why we say above that it's a program?