From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5895 invoked by alias); 23 Aug 2010 16:35:07 -0000 Received: (qmail 5813 invoked by uid 22791); 23 Aug 2010 16:35:02 -0000 X-SWARE-Spam-Status: No, hits=-0.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL,TW_VC,TW_XV X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Mon, 23 Aug 2010 16:34:55 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L7M007005YWL100@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Mon, 23 Aug 2010 19:34:52 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.37.231]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L7M0070Z622LE00@a-mtaout22.012.net.il>; Mon, 23 Aug 2010 19:34:52 +0300 (IDT) Date: Mon, 23 Aug 2010 16:35:00 -0000 From: Eli Zaretskii Subject: Re: [RFA/DOC] record pic In-reply-to: To: Hui Zhu Cc: gdb-patches@sourceware.org, brobecker@adacore.com Reply-to: Eli Zaretskii Message-id: <83hbilnv4n.fsf@gnu.org> References: <83fx039kel.fsf@gnu.org> <83y6c1prnh.fsf@gnu.org> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00388.txt.bz2 > From: Hui Zhu > Date: Mon, 23 Aug 2010 16:25:39 +0800 > Cc: gdb-patches@sourceware.org, Joel Brobecker > > I make a new patch. Please help me review it. Thanks. It's closer, but still not there. > +set record pic hide-nofunction on|off > + The each line or each function will be show in vcg file as a node. > + Sometime, we don't want show it. So hide the nodes. > + Set or show whether `record pic' hides the nodes without function > + name. Rephrase: Normally each line and each function will show up as a node in the VCG file. This command does not save nodes that correspond to functions. Btw, you didn't answer my question what is a "node without function name". Because of this, I'm not sure the above text I suggest is correct. Please explain more about this. > +set record pic hide-nosource on|off > + Set or show whether `record pic' hides the nodes without source line > + debug message. ^^^^^^^^^^^ ^^^^^^^^^^^^^ "source line debug info" > +@kindex record pic > +@item record pic @var{filename} > +Save the execution log to a VCG file @file{@var{filename}}. > +Default filename is @file{gdb_record_@var{process_id}.vcg}, > +where @var{process_id} is the process ID of the inferior. Please add here: @cindex VCG file VCG (Visualization of Compiler Graphs) is a format for textual and readable specification of graph structures. It is used for visualizing large graphs generated by programs. > +Vcgviewer (http://code.google.com/p/vcgviewer/) or xvcg can > +open this file. Please rephrase: Various programs such as @uref{http://code.google.com/p/vcgviewer/, VCGViewer} or @uref{http://rw4.cs.uni-sb.de/users/sander/html/gsvcg1.html, xvcg} can display these files on graphics terminals. > +@kindex set record pic type > +@item set record pic type @var{type} > +Set the type of nodes that @code{record pic} will save. > + > +When @var{type} is set to @code{line} (the default), each node of vcg ^^^ "VCG" (upper case). Also "a VCG file", add "a". > +file that @code{record pic} saved will be a line of the inferior. Each node of a VCG file saved by @code{record pic} will represent a line in the inferior's code. > +When @var{type} is set to @code{function}, each node of vcg file that Again, "a VCG file} > +@code{record pic} saved will be a function of the inferior. ^^^^^^^^^^^^^^^^^^ "will represent a function". Do you mean that all the lines belonging to a function will be represented by a single node? > +@item set record pic hide-nofunction > +The each line or each function will be show in vcg file as a node. > +Sometime, we don't want show it. So hide the nodes. I still don't understand what this means. Will only the function nodes hidden? If so, do you mean that the saved nodes will represent lines, but there will be no nodes that represent functions? How is this different from saying "set record pic line"? > +@item set record pic hide-nosource > +Set whether @code{record pic} hides the nodes without source line > +debug message. ^^^^^^^^^^^^^ "debug information" > +If ON (the default), @code{record pic} will hide the nodes that have > +the same address node in vcg file. And @code{record pic} will show > +the execute count number of this node in format @code{c:number} If ON (the default), @code{record pic} will represent nodes that have the same address as a single node with a count. The count will be in the form @code{c:@var{count}}. > +If OFF, @code{record pic} will show the nodes that have the same > +address node in vcg file. And @code{record pic} will show the > +instruction number in format @code{i:number} that > +@value{record goto} support. Please replace the last sentence with this: Each node will show its instruction count in the form @code{i:@var{num}}. Is this i:NUM display shown always, or is it shown only when nodes with identical addresses are shown individually, as opposed to collapsed into a single node? > +@item show record pic hide-same > +Show the current setting of @code{pic hide-same}. "hide-same" or "hide-sameaddr"?