From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 492053858C52 for ; Thu, 14 Sep 2023 16:40:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 492053858C52 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qgpNo-0001CY-FE; Thu, 14 Sep 2023 12:40:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=6Bp6keyPEe8uL8zon9n3lBiFlx/0rlGcTyahXCQGKqA=; b=HVN3gjpwH2ai VVFa2Ol8AF076GaSxO9FQ1/wAIuuWJmVcLNR5MZovc9SV0ZgWa02ZZF2EsB6qSyFp/Je7Iu9G4m8W vT/6n0bUFBF3eKn6UIaVAQ0PDDj1fJtzlC27BCrw7P56LuxgTHVnyWfz9lZA6Pvf6nrSU0MIMQnUo RnMIUB6wff9T9u1y6TeaqVhgntU1UI88t91Utb1S4dl7R+BVjzzU3TI9k84wvmOEZFOdVTjoK2SAB +2WgkUaZxMB2n237icbvAiV7KZiBrA6zWPeIiyXvMdG+eZUUI1b/2ccYWOqcKcuuAewukQvUlM/Pb RuifQnymw4aWzqc6+CnB+Q==; Date: Thu, 14 Sep 2023 19:39:51 +0300 Message-Id: <83il8clne0.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20230914161433.432600-3-simon.marchi@efficios.com> (message from Simon Marchi via Gdb-patches on Thu, 14 Sep 2023 12:14:19 -0400) Subject: Re: [PATCH v2 3/3] gdb/amdgpu: add precise-memory support References: <20230914161433.432600-1-simon.marchi@efficios.com> <20230914161433.432600-3-simon.marchi@efficios.com> X-Spam-Status: No, score=-5.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Simon Marchi > Date: Thu, 14 Sep 2023 12:14:19 -0400 > From: Simon Marchi via Gdb-patches > > gdb/amd-dbgapi-target.c | 173 +++++++++++++++++- > gdb/doc/gdb.texinfo | 43 +++++ > gdb/testsuite/gdb.rocm/precise-memory-exec.c | 44 +++++ > .../gdb.rocm/precise-memory-exec.exp | 58 ++++++ > gdb/testsuite/gdb.rocm/precise-memory-fork.c | 41 +++++ > .../gdb.rocm/precise-memory-fork.exp | 50 +++++ > .../precise-memory-multi-inferiors.exp | 87 +++++++++ > .../precise-memory-warning-sigsegv.cpp | 33 ++++ > .../precise-memory-warning-sigsegv.exp | 45 +++++ > gdb/testsuite/gdb.rocm/precise-memory.cpp | 32 ++++ > gdb/testsuite/gdb.rocm/precise-memory.exp | 57 ++++++ > gdb/testsuite/lib/rocm.exp | 19 ++ > 12 files changed, 677 insertions(+), 5 deletions(-) > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.c > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-exec.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.c > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-fork.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-multi-inferiors.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.cpp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory-warning-sigsegv.exp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.cpp > create mode 100644 gdb/testsuite/gdb.rocm/precise-memory.exp Thanks. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index 9b7e06f31566..aa3c67788871 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo This part is OK. Reviewed-By: Eli Zaretskii