From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C349F3858CD1 for ; Fri, 8 Sep 2023 15:35:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C349F3858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qedWX-00024f-L1; Fri, 08 Sep 2023 11:35:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=zfrQeLWdodJ7L6URPXe9UoL12rsm8rGSuCIdqbgvG1s=; b=RvLj/1FSsEi4 FKPHJt9VuGcPZQJf7t9PlDe0fE566rHlYWl7ZNCM/n4reZwUzCsPr/EpF3/gzum81nXM2v5sL/9EF d80aUYONeGyzDkA1yUpcZ8fpw57OmONaa4K9juH1Yj2gmwCsKkG5npmHd0wuQEF5Cs5JA/6a4XWvW vv8YKOlooxa0SOmxdTD2Dssl/KeevRpycfa/QViV3+Du0TBh/KjE5TPrvW/F2WNE4zdWJfV6Xc5sr xGPrFpcqZtxi+ioxJzqIPYpBbSn9sicnlHFvTeVxOt74ebkXBQzXUzeaVx3tmhzms5y43w3LrtbBl EXGm6eA6hS7Y2N5OD02DnQ==; Date: Fri, 08 Sep 2023 18:35:45 +0300 Message-Id: <83il8kwucu.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20230908152102.32731-2-simon.marchi@efficios.com> (message from Simon Marchi via Gdb-patches on Fri, 8 Sep 2023 11:20:58 -0400) Subject: Re: [PATCH 2/2] gdb/doc: describe x87 registers References: <20230908152102.32731-1-simon.marchi@efficios.com> <20230908152102.32731-2-simon.marchi@efficios.com> X-Spam-Status: No, score=0.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Simon Marchi > Date: Fri, 8 Sep 2023 11:20:58 -0400 > From: Simon Marchi via Gdb-patches > > While investigating this [1], I initially had no idea what register > "fioff" stood for, making it difficult to map it to something in the > Intel or AMD manuals. Similarly, I can imaging someone familiar with > x87 to want to print the "x87 last instruction address", and have no > clue that GDB makes it available as register "fioff". The names of the > x87 state fields don't seem to be standardized, they even change between > sections of the Intel manual (between the FSAVE, FXSAVE and XSAVE area > descriptions). > > Add some details to the doc to help one map GDB register names to x87 > state fields. > > [1] https://inbox.sourceware.org/gdb-patches/20230908022722.430741-1-simon.marchi@efficios.com/T/#u > > Change-Id: I0ea1eb648358e62da4aa87eea3515ee8a09f2762 > --- > gdb/doc/gdb.texinfo | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) Thanks, such additions are always welcome. Approved-By: Eli Zaretskii