From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id C841C3858D3C for ; Tue, 25 Jul 2023 14:07:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C841C3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOIgp-0006kD-M8; Tue, 25 Jul 2023 10:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=w4yekgWpgJlVw4I5bJ9j2cHnpqLAdI2aIXvHtupsT6k=; b=l4+Hh/u+gX0E ubSRO0+cEbs5GC5oRsH9GsZYpZWieRxUWKUYIcp+qr1X0OJEEiVTwcBOvdH17oOLJBhfKNd1YcOKu 6A4/lHQLFMoHKRaqVLdZ+JC2eg70bu/PVcV0r+QZYPQe8XSH8UEp/fqUwlHixhsYTPodCsAGgthz8 FkebC3vfCgI1xCQVwncFjy88u5hlINgsNKTpfz70aqnW9FaspJ6Bpj9XVy8VB+lK3vRGhNdsn2ZZZ IHHD6iTjVwl4Euu+B2UhIrtTXr4j7lgVffPKntc2cOhei9zcBS/2h18mNPfy6Zzv/Zd894SSphr2g kT8Al4nzmqxxQtm1w/TMfQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOIgo-0002Mg-9l; Tue, 25 Jul 2023 10:07:03 -0400 Date: Tue, 25 Jul 2023 17:07:48 +0300 Message-Id: <83ila8ozij.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20230725-dap-bt-path-v1-3-bb015b0d8e54@adacore.com> (message from Tom Tromey via Gdb-patches on Tue, 25 Jul 2023 07:49:40 -0600) Subject: Re: [PATCH 3/6] Add "cwd" parameter to DAP launch request References: <20230725-dap-bt-path-v1-0-bb015b0d8e54@adacore.com> <20230725-dap-bt-path-v1-3-bb015b0d8e54@adacore.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 25 Jul 2023 07:49:40 -0600 > From: Tom Tromey via Gdb-patches > > This adds the "cwd" parameter to the DAP launch request. > > This came up here: > https://github.com/eclipse-cdt-cloud/cdt-gdb-adapter/issues/90 > ... and seemed like a good idea. > --- > gdb/doc/gdb.texinfo | 8 ++++++++ > gdb/python/lib/gdb/dap/launch.py | 34 ++++++++++++++++----------------- > gdb/testsuite/gdb.dap/cwd.exp | 40 +++++++++++++++++++++++++++++++++++++++ > gdb/testsuite/lib/dap-support.exp | 5 +++++ > 4 files changed, 70 insertions(+), 17 deletions(-) OK for the documentation part, thanks. Reviewed-By: Eli Zaretskii