From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 1E9A53873BCD for ; Tue, 21 Feb 2023 12:43:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1E9A53873BCD Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURzF-0006SD-K5; Tue, 21 Feb 2023 07:43:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RpgHwLeDcgHEPCX5cnW0fwpbB4J/9V6zKhnwU+GvMWw=; b=LCPGEZzozUrT VD48JKCltwEBOR2qMjk7hHzpBipr1B30qdtA5jY7MtGLpCpCRCU53jwMFiaXRC9tiTbp4rFWGqR0b i4K5gIrxEnfBXYrloHHxE9aWPL7HDFe0e6zLewPbGw3UPK0uB2u78+EE7aPOvyoQ9gw70DDCNAoBa CKpmQyTGLzWP/89QqWXDTIBDpHvobGDugcmA+70VXBoEzrDQ6rDhkUTVkJgVEjYy5QBMrb6c/kUBA wBthcBE4UTl5HulOB0eYH8uGWr7FH5gM0O79H7AM71TFTjbfr3WBYCE0u4jT1flDfQ2J85W2n6Mdf 3911jt45PzixcLaGC+MA0g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pURzF-00044o-28; Tue, 21 Feb 2023 07:43:13 -0500 Date: Tue, 21 Feb 2023 14:43:23 +0200 Message-Id: <83ilfvtcic.fsf@gnu.org> From: Eli Zaretskii To: Christina Schimpe Cc: gdb-patches@sourceware.org In-Reply-To: <20230221090501.1487842-2-christina.schimpe@intel.com> (message from Christina Schimpe via Gdb-patches on Tue, 21 Feb 2023 10:05:01 +0100) Subject: Re: [PATCH 1/1] gdb, breakpoint: add breakpoint location debugging logs References: <20230221090501.1487842-1-christina.schimpe@intel.com> <20230221090501.1487842-2-christina.schimpe@intel.com> X-Spam-Status: No, score=1.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Date: Tue, 21 Feb 2023 10:05:01 +0100 > From: Christina Schimpe via Gdb-patches > > From: Mihails Strasuns > > Add new commands: > > set debug breakpoints on|off > show debug breakpoints > > This patch introduces new debugging information that prints > breakpoint location insertion and removal flow. > > The debug output looks like: > ~~~ > (gdb) set debug breakpoints on > (gdb) disassemble main > Dump of assembler code for function main: > 0x0000555555555129 <+0>: endbr64 > 0x000055555555512d <+4>: push %rbp > 0x000055555555512e <+5>: mov %rsp,%rbp > => 0x0000555555555131 <+8>: mov $0x0,%eax > 0x0000555555555136 <+13>: pop %rbp > 0x0000555555555137 <+14>: ret > End of assembler dump. > (gdb) break *0x0000555555555137 > Breakpoint 2 at 0x555555555137: file main.c, line 4. > [breakpoints] update_global_location_list: UGLL_MAY_INSERT > (gdb) c > Continuing. > [breakpoints] update_global_location_list: UGLL_INSERT > [breakpoints] insert_bp_location: bp_location (0x562881637fb0) at address 0x555555555137 in main at main.c:4 > [breakpoints] insert_bp_location: bp_location (0x56288179a4f0) at address 0x7ffff7fd37b5 > [breakpoints] insert_bp_location: bp_location (0x56288179ea60) at address 0x7ffff7fe509e > [breakpoints] insert_bp_location: bp_location (0x5628817184d0) at address 0x7ffff7fe63f4 <_dl_close_worker+2356> > [breakpoints] remove_breakpoint_1: bp_location (0x562881637fb0) due to regular remove at address 0x555555555137 in main at main.c:4 > [breakpoints] remove_breakpoint_1: bp_location (0x56288179a4f0) due to regular remove at address 0x7ffff7fd37b5 > [breakpoints] remove_breakpoint_1: bp_location (0x56288179ea60) due to regular remove at address 0x7ffff7fe509e > [breakpoints] remove_breakpoint_1: bp_location (0x5628817184d0) due to regular remove at address 0x7ffff7fe63f4 <_dl_close_worker+2356> > > Breakpoint 2, 0x0000555555555137 in main () at main.c:4 > 4 } > ~~~ > > Co-Authored-By: Christina Schimpe > --- > gdb/NEWS | 4 +++ > gdb/breakpoint.c | 66 +++++++++++++++++++++++++++++++++++++++++++++ > gdb/doc/gdb.texinfo | 8 ++++++ > 3 files changed, 78 insertions(+) Thanks, the documentation parts are okay. Reviewed-By: Eli Zaretskii