From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 479983856DC1 for ; Wed, 25 May 2022 13:58:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 479983856DC1 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33424) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntrWT-0005rU-An; Wed, 25 May 2022 09:58:01 -0400 Received: from [87.69.77.57] (port=3739 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ntrWS-0006NY-Qk; Wed, 25 May 2022 09:58:01 -0400 Date: Wed, 25 May 2022 16:57:52 +0300 Message-Id: <83ilpt4sv3.fsf@gnu.org> From: Eli Zaretskii To: Pedro Alves Cc: schwab@linux-m68k.org, gdb-patches@sourceware.org In-Reply-To: <4e4684b5-9b8c-d46d-4d32-f2f503d40cf2@palves.net> (message from Pedro Alves on Tue, 24 May 2022 20:49:36 +0100) Subject: Re: [PATCH] Show enabled locations with disabled breakpoint parent as "y-" (Re: [PATCH 0/2] info breakpoints improvements) References: <20220519215552.3254012-1-pedro@palves.net> <70ddb0b0-7c7d-3bcd-ef3d-246290ae1edf@arm.com> <1e932144-4f4d-4c10-bbaa-deef05684895@palves.net> <83fskz5aol.fsf@gnu.org> <0247c63e-189d-0a71-8b5f-257fd83ff6a3@palves.net> <83czg359mz.fsf@gnu.org> <45d7d87f-f78a-7c6b-28d7-285beecf9a8a@palves.net> <83bkvn58pe.fsf@gnu.org> <87sfozowak.fsf@igel.home> <05b3833a-9d87-53d2-e0a9-5b481e597929@palves.net> <4e4684b5-9b8c-d46d-4d32-f2f503d40cf2@palves.net> X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2022 13:58:03 -0000 > Date: Tue, 24 May 2022 20:49:36 +0100 > From: Pedro Alves > Cc: Eli Zaretskii > > >> I think it would be better in that case to omit the column or display it > >> as "-", to indicate that it is ignored right now. > >> > > > > Yes, we could print them differently, preserving the user-specified enable/disable > > state. We print them in uppercase N/Y when the location is disabled due to an invalid > > condition already, for example. > > Here's a patch. Code, manual, NEWS, testcase, all included. Thanks, the documentation parts are okay.