From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id DA81B3858C2C
 for <gdb-patches@sourceware.org>; Thu, 10 Mar 2022 06:38:02 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA81B3858C2C
Received: from [2001:470:142:3::e] (port=51238 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSCR0-0003LD-Ap; Thu, 10 Mar 2022 01:38:02 -0500
Received: from [87.69.77.57] (port=1247 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSCQz-0001lL-Og; Thu, 10 Mar 2022 01:38:02 -0500
Date: Thu, 10 Mar 2022 08:38:00 +0200
Message-Id: <83ilsme2if.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220310003152.80655-1-tom@tromey.com> (message from Tom Tromey
 on Wed, 9 Mar 2022 17:31:52 -0700)
Subject: Re: [PATCH] Style URLs in GDB output
References: <20220310003152.80655-1-tom@tromey.com>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2022 06:38:03 -0000

> From: Tom Tromey <tom@tromey.com>
> Date: Wed,  9 Mar 2022 17:31:52 -0700
> Cc: Tom Tromey <tom@tromey.com>
> 
> I noticed that GDB will display URLs in a few spots.  This changes
> them to be styled.  Originally I thought I'd introduce a new "url"
> style, but there aren't many places to use this, so I just reused
> filename styling instead.  This patch also changes the debuginfod URL
> list to be printed one URL per line.  I think this is probably a bit
> easier to read.

File-name styling for URLs is fine, IMO.  We don't need to invent a
new style.

>  gdb/debuginfod-support.c         | 25 +++++++++++++++++++++----
>  gdb/doc/gdb.texinfo              |  2 +-
>  gdb/testsuite/gdb.base/style.exp |  5 +++--
>  gdb/top.c                        | 10 +++++++---
>  4 files changed, 32 insertions(+), 10 deletions(-)

The documentation part of the patch is OK, thanks.