From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 091C93858032
 for <gdb-patches@sourceware.org>; Tue, 22 Feb 2022 14:48:40 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 091C93858032
Received: from [2001:470:142:3::e] (port=50054 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nMWT1-00070y-JH; Tue, 22 Feb 2022 09:48:39 -0500
Received: from [87.69.77.57] (port=1902 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nMWT1-0006J6-29; Tue, 22 Feb 2022 09:48:39 -0500
Date: Tue, 22 Feb 2022 16:48:46 +0200
Message-Id: <83ilt7t0s1.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <87sfsbattq.fsf@redhat.com> (message from Andrew Burgess on Tue, 
 22 Feb 2022 13:56:17 +0000)
Subject: Re: [PATCH] gdb/python: add gdb.Architecture.format_address
References: <20220211161721.3252422-1-aburgess@redhat.com>
 <83leyhs07f.fsf@gnu.org> <878ru4cepy.fsf@redhat.com> <837d9oumhd.fsf@gnu.org>
 <87sfsbattq.fsf@redhat.com>
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Feb 2022 14:48:41 -0000

> From: Andrew Burgess <aburgess@redhat.com>
> Cc: gdb-patches@sourceware.org
> Date: Tue, 22 Feb 2022 13:56:17 +0000
> 
> So, appologies, but this is another complete rewrite of the docs.  With
> the exception of the name, for which I still have no better suggestions,
> how's this?

Let's see...

> +@defun Architecture.format_address (@var{address})
> +Return a string in the format @samp{@var{addr}
> +<@var{symbol}+@var{offset}>}, where @var{addr} is @var{address}
> +formatted in hexadecimal, @var{symbol} is the closest earlier symbol
> +to @var{address}, and @var{offset} is the offset from @var{symbol} to
> +@var{address} in decimal.

I think instead of "closest earlier" it would be best to say

  ... @var{symbol} is the symbol whose address is the nearest to
  @var{address} and below it in memory ...

Other than that, SGTM, thanks.