From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <andrew.burgess@embecosm.com>
Cc: gdb-patches@sourceware.org, palves@redhat.com
Subject: Re: [PATCH 2/2] gdb: Rework command completion on 'tui reg'.
Date: Tue, 02 Jun 2015 15:01:00 -0000 [thread overview]
Message-ID: <83iob6rw7y.fsf@gnu.org> (raw)
In-Reply-To: <20150602101111.GO17330@embecosm.com>
> Date: Tue, 2 Jun 2015 11:11:11 +0100
> From: Andrew Burgess <andrew.burgess@embecosm.com>
> Cc: Pedro Alves <palves@redhat.com>
>
> Thanks for the review. I've reworked the patch to address all the
> issues raised. Here's the new version.
Thanks.
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -52,6 +52,9 @@
>
> * GDB now supports the vector ABI on S/390 GNU/Linux targets.
>
> +* The "tui reg" command now provides completion for all of the
> + available register groups, including target specific groups.
This part is OK.
> +Changes the register group displayed in the tui register window to
> +@var{group}. If the register window is not currently displayed this
> +command will cause the register window to be displayed. The list of
> +register groups, as well as their order is target specific. The
> +following groups are avaiable on most targets: ^^
Two spaces between sentences, please.
> +@table @code
> +@item next
> +Repeatedly selecting this group will cause the display to cycle
> +through all of the available register groups.
> +
> +@item prev
> +Repeatedly selecting this group will cause the display to cycle
> +through all of the available register groups in the reverse order to
> +@var{next}.
> +
> +@item general
> +Display the general registers.
> +@item float
> +Display the floating point registers.
> +@item system
> +Display the system registers.
> +@item vector
> +Display the vector registers.
> +@item all
> +Display all registers.
> +@end table
Please keep one empty line before each @item, for consistency.
The documentation part is OK with those fixed.
next prev parent reply other threads:[~2015-06-02 15:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-21 22:17 [PATCH 0/2] Improvements to 'tui reg' command Andrew Burgess
2015-05-21 22:17 ` [PATCH 1/2] gdb: Add 'tui reg prev' command Andrew Burgess
2015-05-22 1:06 ` Pedro Alves
2015-05-22 16:37 ` Andrew Burgess
2015-05-22 17:06 ` Pedro Alves
2015-05-22 7:15 ` Eli Zaretskii
2015-05-21 22:17 ` [PATCH 2/2] gdb: Rework command completion on 'tui reg' Andrew Burgess
2015-05-23 13:18 ` Pedro Alves
2015-06-02 10:11 ` Andrew Burgess
2015-06-02 15:01 ` Eli Zaretskii [this message]
2015-06-09 16:45 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83iob6rw7y.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=andrew.burgess@embecosm.com \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).