From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119195-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 30171 invoked by alias); 19 Jan 2015 17:55:48 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 30160 invoked by uid 89); 19 Jan 2015 17:55:46 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout29.012.net.il
Received: from mtaout29.012.net.il (HELO mtaout29.012.net.il) (80.179.55.185) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jan 2015 17:55:46 +0000
Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NIF00500QJ4XG00@mtaout29.012.net.il> for gdb-patches@sourceware.org; Mon, 19 Jan 2015 19:52:24 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIF0016MQZCG660@mtaout29.012.net.il>; Mon, 19 Jan 2015 19:52:24 +0200 (IST)
Date: Mon, 19 Jan 2015 17:55:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] Speed up "gdb -tui" output
In-reply-to: <21677.44074.982761.250152@ruffy2.mtv.corp.google.com>
To: Doug Evans <dje@google.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iog2y7s9.fsf@gnu.org>
References: <83zj9v7urq.fsf@gnu.org> <CADPb22Q7oD3K-dYkngEPDBbV++mLCKifTEmvJczQ=0h2FX0yXA@mail.gmail.com> <83sifn7mpt.fsf@gnu.org> <CADPb22QeiSrzD81kMJeqpnDBrx1DybpbGmHc1r0koGDtqAu8tw@mail.gmail.com> <83h9w278a9.fsf@gnu.org> <CADPb22R_=xwonUGJMxJRtAbbK8OcSmU5ojarB=T9wjg9YEtE6Q@mail.gmail.com> <83bnma75yt.fsf@gnu.org> <CADPb22SvEa8-+y009ET7PQDuYixGEK6LbrJr_pyQ98SfVy_iJg@mail.gmail.com> <837fwy74ny.fsf@gnu.org> <CADPb22QZ8qgfYfsT=wxQg8yKRE3EzPTc8QHcHpk8oXpA6DsA2A@mail.gmail.com> <21677.44074.982761.250152@ruffy2.mtv.corp.google.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00529.txt.bz2

> From: Doug Evans <dje@google.com>
> Date: Wed, 7 Jan 2015 13:59:06 -0800
> 
> Doug Evans writes:
>  > Seems like the main source of the problem would be gdb_stdout,
>  > so let's try to fix that first and go from there.
> 
> Here's a prototype.

Sorry for a long delay.  I tried this (and Pedro's) patch today.  They
both do the job, so one of them should IMO be committed, master and
branch.

> @@ -239,6 +243,12 @@ tui_file_flush (struct ui_file *file)
>      case astring:
>        break;
>      case afile:
> +      /* There is also gdb_stdlog, gdb_stdtarg, gdb_stdtargerr, but
> +	 tui_setup_io maps those to gdb_stderr.  OTOH, do we need to make
> +	 this conditional?  */
> +      if (file == gdb_stdout
> +	  || file == gdb_stderr)
> +	tui_refresh_cmd_win ();

I indeed think that the condition should be removed.  I see no need
for it: there's no reason to make any stream displayed on TUI more
than line-buffered.

Thanks.