From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-119135-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 14130 invoked by alias); 16 Jan 2015 16:43:46 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 14112 invoked by uid 89); 16 Jan 2015 16:43:45 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout25.012.net.il
Received: from mtaout25.012.net.il (HELO mtaout25.012.net.il) (80.179.55.181) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Jan 2015 16:43:43 +0000
Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NIA0000036BG300@mtaout25.012.net.il> for gdb-patches@sourceware.org; Fri, 16 Jan 2015 18:39:10 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NIA0025F3L92K00@mtaout25.012.net.il>; Fri, 16 Jan 2015 18:39:10 +0200 (IST)
Date: Fri, 16 Jan 2015 16:43:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH] TUI: Expand TABs into spaces
In-reply-to: <CAP9bCMSbzc3q5CmJQDZyL0utP_x6Sp8ekHaTHzJHyVCJRwwcWA@mail.gmail.com>
To: Doug Evans <xdje42@gmail.com>
Cc: gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83iog61xrl.fsf@gnu.org>
References: <83k3149k5b.fsf@gnu.org> <837fwn2cvc.fsf@gnu.org> <CAP9bCMSbzc3q5CmJQDZyL0utP_x6Sp8ekHaTHzJHyVCJRwwcWA@mail.gmail.com>
X-IsSubscribed: yes
X-SW-Source: 2015-01/txt/msg00469.txt.bz2

> Date: Fri, 16 Jan 2015 08:32:15 -0800
> From: Doug Evans <xdje42@gmail.com>
> Cc: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> 
> >> 2015-01-03  Eli Zaretskii  <eliz@gnu.org>
> >>
> >>       * tui/tui-regs.c (tui_register_format): Expand TABs into the
> >>       appropriate number of spaces.
> >>
> >>       * tui/tui-io.c (tui_puts, tui_redisplay_readline): Expand TABs
> >>       into the appropriate number of spaces.
> 
> I'd have to read the patch more to say it's ok,
> but one thing that is missing are comments
> explaining *why* we are expanding tabs into spaces.

You mean, the fact that the Windows port of ncurses doesn't?  Sure,
can do that.  But note that a similar feature in displaying the source
doesn't have any such comments.