From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: RFC: add relative file name handling for linespecs
Date: Tue, 10 Jan 2012 17:40:00 -0000 [thread overview]
Message-ID: <83ipkjeagi.fsf@gnu.org> (raw)
In-Reply-To: <m3d3arlez3.fsf@fleche.redhat.com>
> From: Tom Tromey <tromey@redhat.com>
> Date: Tue, 10 Jan 2012 09:06:08 -0700
>
> This needs at least a doc review.
Thanks, the documentation parts are okay.
> +/* See whether FILENAME matches SEARCH_NAME using the rule that we
> + advertise to the user.
Why not say explicitly how the names are matched? "The rule we
advertise" doesn't give any hint where to look for that rule, so the
issue remains a mystery and requires to read the source to glean what
this does.
> + /* Either the names must completely match, or the character
> + preceding the trailing SEARCH_NAME segment of FILENAME must be a
> + directory separator. */
> + return (len == search_len
> + || IS_DIR_SEPARATOR (filename[len - search_len - 1]));
What about the (somewhat perverse) case of "d:foo/bar" and "foo/bar"
on Windows?
next prev parent reply other threads:[~2012-01-10 17:25 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 16:32 Tom Tromey
2012-01-10 17:40 ` Eli Zaretskii [this message]
2012-01-11 21:52 ` Tom Tromey
2012-01-12 6:23 ` Eli Zaretskii
2012-01-16 19:01 ` Tom Tromey
2012-12-08 16:34 ` Jan Kratochvil
2012-12-08 18:33 ` Eli Zaretskii
2013-01-07 15:17 ` [testcase patch] New testcase: DOS drive letters in linespec [Re: RFC: add relative file name handling for linespecs] Jan Kratochvil
2013-01-17 20:42 ` [commit] " Jan Kratochvil
2012-01-11 9:03 ` RFC: add relative file name handling for linespecs Joel Brobecker
2012-01-16 19:29 ` Tom Tromey
2012-01-16 21:07 ` Tom Tromey
2012-01-19 15:39 ` Performance regression (12x): " Jan Kratochvil
2012-01-19 16:35 ` Tom Tromey
2012-01-31 20:18 ` Tom Tromey
2012-02-01 10:22 ` Joel Brobecker
2012-02-01 15:04 ` Tom Tromey
2012-02-01 15:07 ` Tom Tromey
2012-02-01 15:18 ` Joel Brobecker
2012-02-01 15:35 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ipkjeagi.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).