From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id CC1033857346 for ; Tue, 20 Jun 2023 16:22:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org CC1033857346 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBe84-0005ci-E2; Tue, 20 Jun 2023 12:22:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/Trst/oL5tjkEmPWxgcanRHSPdzoa0flp/F4I3Fo3YI=; b=jwba8/kdn4gE e+GvtpyWIpsuTE8Lypyk4Wun8UjyfQKB5Qr61FN+pY35w5qSVZQaEzN2M1sydhuyRR95BqvmK8YGp 9pwNGIWwlsnjQA+gy4YDCMEbxmsnN1hK3c7TyNjE3Ec23Uh3s/Yr1ALIf9cRJ1vJskDqh3DQbmvMu Jr5PimU8i7ONe4+Fd0rCaPK4eDCy9zLEuF0Wnw2ZamMwptnenPGN8nmhy+sz9uzODlNkPs9ybPlE3 7/XuFilQmNdGqMD2TGv4AgPC/2uK6TjAlfuu11doARTk1kEYoY7WzxF2jN7iJir0bgn+96UZn7H8O MhshB1B3gUk/qq7s1OoYRA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qBe83-00053d-Uj; Tue, 20 Jun 2023 12:22:52 -0400 Date: Tue, 20 Jun 2023 19:22:59 +0300 Message-Id: <83jzvy5cik.fsf@gnu.org> From: Eli Zaretskii To: Bruno Larsen Cc: gdb-patches@sourceware.org In-Reply-To: <20230620155259.2476415-4-blarsen@redhat.com> (message from Bruno Larsen on Tue, 20 Jun 2023 17:52:59 +0200) Subject: Re: [PATCH v2 3/4] gdb/cli: add '.' as an argument for 'list' command References: <20230620155259.2476415-1-blarsen@redhat.com> <20230620155259.2476415-4-blarsen@redhat.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Bruno Larsen > Cc: eliz@gnu.org, > Bruno Larsen > Date: Tue, 20 Jun 2023 17:52:59 +0200 > > diff --git a/gdb/NEWS b/gdb/NEWS > index c5519e320e6..aa14e64e51c 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -85,6 +85,10 @@ > is either the last solitary line printed (if there was one) or around > the main function. > > +* The 'list' command now accepts '.' as an argument, which tells GDB to > + print the location where the inferior is stopped. If the inferior hasn't > + started yet, the command will error out. This part is OK. > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -9151,8 +9151,14 @@ it prints the lines around the function @code{main}. > > @item list - > Print lines just before the lines last printed. > + > +@item list . > +Print the lines surrounding the location that is currently being > +examined by the user (that is, the lines around the last solitary > +line printed). The text in NEWS mentioned the place where the inferior is stopped, which I think is an important information. This text omits this for some reason. How about adding it here? Thanks. Reviewed-By: Eli Zaretskii