From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 7C250385354A for ; Thu, 18 May 2023 15:19:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7C250385354A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfPu-0002Rp-7h; Thu, 18 May 2023 11:19:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HHPFE+6vPLyE/7fmpbEDCqYQeOH1Ob8KKOzc2O5BADM=; b=oHaXWfmCowF8 6ZoFFA73BU3iWl8PD9MYfpSK4NPs0sORmB/cVh4S+p4bI8eiVpsQlmj4cw0E7mkQ+PFxbS1+HhURY YhlmUrQPsy7pXbsCOL7p7XNzw7zgQA9XjoSFfBn6/Cu4oO/Cca5yNf/mxglBynQ2NxRF9QrO45ADL t1rR3vHS6nwfLo3ImimduV5eVR7xbU2bue/fNiYku7Zu29t69G56PfF06L1tO+Tzq/tlTV/65P31X Dx2WEz62C78PoeUi9zxihL+84NdO9Xo1lU4Hfj58fZLME1cOlKU8iwixS1+wqaaYYo6S+6b4+r+P/ 40tlnLin9SCGI13ves/miQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzfPt-0007fz-FC; Thu, 18 May 2023 11:19:45 -0400 Date: Thu, 18 May 2023 18:19:58 +0300 Message-Id: <83jzx5vf8h.fsf@gnu.org> From: Eli Zaretskii To: Simon Farre Cc: gdb-patches@sourceware.org In-Reply-To: <20230518144552.67097-1-simon.farre.cx@gmail.com> (message from Simon Farre via Gdb-patches on Thu, 18 May 2023 16:45:52 +0200) Subject: Re: [PATCH v2] [gdb/infcmd]: Add next-expression command References: <20230518144552.67097-1-simon.farre.cx@gmail.com> X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Simon Farre > Date: Thu, 18 May 2023 16:45:52 +0200 > From: Simon Farre via Gdb-patches > > gdb/NEWS | 7 ++++ > gdb/buildsym-legacy.c | 4 +- > gdb/buildsym-legacy.h | 2 +- > gdb/buildsym.c | 3 +- > gdb/buildsym.h | 4 +- > gdb/coffread.c | 4 +- > gdb/dbxread.c | 6 +-- > gdb/doc/gdb.texinfo | 16 +++++++- > gdb/doc/python.texi | 6 +++ > gdb/dwarf2/read.c | 32 ++++++++++----- > gdb/gdbthread.h | 2 + > gdb/infcmd.c | 91 +++++++++++++++++++++++++++++++++++------- > gdb/infrun.c | 8 ++++ > gdb/mdebugread.c | 2 +- > gdb/python/py-symtab.c | 29 ++++++++++---- > gdb/stack.c | 7 ++++ > gdb/symtab.c | 1 + > gdb/symtab.h | 22 ++++++++++ > 18 files changed, 201 insertions(+), 45 deletions(-) Thanks. > diff --git a/gdb/NEWS b/gdb/NEWS > index b82114d80b0..38c6f54564b 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,13 @@ > > *** Changes since GDB 13 > > +* New commmand "next-expression" ("ne") that steps by expression or statement > + on a single source line if debug information is available. > + > +* New column attribute of Python type Symtab_and_line to reflect the added > + column field on "linetable_entry". Describes what column on the source line ^^ Two spaces there. > + that is being executed. Columns are byte-level coordinates on a source line. ^^ And there. > --- a/gdb/doc/python.texi > +++ b/gdb/doc/python.texi > @@ -5899,6 +5899,12 @@ Indicates the current line number for this object. This > attribute is not writable. > @end defvar > > +@defvar Symtab_and_line.column > +Indicates the current column number for this object. This > +attribute is not writeable. A source-line column is it's byte position ^^^^ "its', not "it's". Reviewed-By: Eli Zaretskii