From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 07A2E3858D28 for ; Fri, 8 Apr 2022 19:43:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07A2E3858D28 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44936) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncuWO-0005IU-Fr; Fri, 08 Apr 2022 15:43:52 -0400 Received: from [87.69.77.57] (port=2786 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ncuWN-0001SC-V4; Fri, 08 Apr 2022 15:43:52 -0400 Date: Fri, 08 Apr 2022 22:44:04 +0300 Message-Id: <83k0bz9x8b.fsf@gnu.org> From: Eli Zaretskii To: Nils-Christian Kempke Cc: gdb-patches@sourceware.org In-Reply-To: <20220408134900.2635299-2-nils-christian.kempke@intel.com> (message from Nils-Christian Kempke on Fri, 8 Apr 2022 15:49:00 +0200) Subject: Re: [PATCH v2 11/11] gdb/doc: add section about fortran intrinsic functions and types References: <20220408134900.2635299-1-nils-christian.kempke@intel.com> <20220408134900.2635299-2-nils-christian.kempke@intel.com> X-Spam-Status: No, score=2.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: ** X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 08 Apr 2022 19:43:58 -0000 > From: Nils-Christian Kempke > Cc: eliz@gnu.org, > Nils-Christian Kempke > Date: Fri, 8 Apr 2022 15:49:00 +0200 > > The earlier version of this document had no sections about the > available Fortran intrinsic functions or the Fortran builtin types. > > I added two sections 'Fortran intrinsics' and 'Fortran types' to > document the available Fortran language features. > --- > gdb/doc/gdb.texinfo | 147 +++++++++++++++++++++++++++++++++++++++++--- > 1 file changed, 137 insertions(+), 10 deletions(-) Thanks. > +@node Fortran Defaults > +@subsubsection Fortran Defaults > + > +@cindex Fortran Defaults > + > +Fortran symbols are usually case-insensitive, so @value{GDBN} by > +default uses case-insensitive matches for Fortran symbols. You can > +change that with the @samp{set case-insensitive} command, see > +@ref{Symbols}, for the details. Does such a short text justify a full @node? Why not make it part of another node, for example the top-level @subsection about Fortran? > +Generally, the actual implementation of the @code{KIND} type parameter is > +compiler specific. In @value{GDBN} the kind parameter is implemented in > +accordance to its use in the @sc{gnu} gfortran compiler. Here, the kind ^^^^^^^^^^^^^ "In accordance with". Also, "gfortran" is the name of a command, so please give it the @command markup. > +parameter for a given @var{type} specifies its size in memory - a Fortran ^ Please use "--" or even "---" there, they produce a nicer hyphen in the manual. > +For every type there is also a default kind associated with it, e.g. You need a @: after "e.g.", so that the period is not treated as the end of a sentence. > +@item Logical > +@code{Locigal*1}, @code{Locigal*2}, @code{Locigal*4}, @code{Locigal*8}, and > +@code{Locigal} = @code{Locigal*4}. Typos: "Locigal" should be "Logical". > +@item ASSOCIATED(@var{pointer} [, @var{target}]) > +Returns the association status of the pointer @var{pointer} or if @var{target} > +is present whether @var{pointer} is associated with the target @var{target}. Punctuation: "or, if @var{target} is present, whether ..." > +@item CMPLX(@var{X} [, @var{Y} [, @var{kind}]]) > +Returns a complex number where @var{x} is converted to the real component. If > +@var{y} is present it is converted to the imaginary component. If @var{y} is "x" and "y" should have consistent letter-case (I think they all should be lower-case). > +@item FLOOR(@var{a} [, @var{kind}]) > +Computes the greatest integer less than or equal to @var{A}. The optional Likewise for "a". > +@item UBOUND(@var{array} [, @var{dim} [, @var{kind}]]) > +Returns the upper bounds of an @var{array}, or a single lower bound along the ^^^^^ "upper", I guess?