From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id A3D303857023
 for <gdb-patches@sourceware.org>; Tue, 15 Jun 2021 13:52:37 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A3D303857023
Received: from fencepost.gnu.org ([2001:470:142:3::e]:54152)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1lt9UY-000202-Id; Tue, 15 Jun 2021 09:52:34 -0400
Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1582
 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1lt9UI-0006xm-MQ; Tue, 15 Jun 2021 09:52:34 -0400
Date: Tue, 15 Jun 2021 16:52:14 +0300
Message-Id: <83k0mv44mp.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Willgerodt, Felix" <felix.willgerodt@intel.com>
Cc: markus.t.metzger@intel.com, gdb-patches@sourceware.org
In-Reply-To: <ac11ed45d339483e8efee53d4c8f42af@intel.com>
 (felix.willgerodt@intel.com)
Subject: Re: [PATCH v2 12/12] btrace: Extend ptwrite event decoding.
References: <20210614145411.689277-1-felix.willgerodt@intel.com>
 <20210614145411.689277-8-felix.willgerodt@intel.com> <83wnqv4a9z.fsf@gnu.org>
 <ac11ed45d339483e8efee53d4c8f42af@intel.com>
X-Spam-Status: No, score=2.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.2
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Jun 2021 13:52:38 -0000

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "Metzger, Markus T" <markus.t.metzger@intel.com>,
> 	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tue, 15 Jun 2021 13:40:40 +0000
> 
> >> +@smallexample
> >> +@group
> >> +(gdb) python-interactive
> >> +>>> class my_listener(object):
> >> +...    def __init__(self):
> >> +...        self.variable = 0
> >> +...    def __call__(self, payload, ip):
> >> +...        if gdb.selected_thread().global_num == 1:
> >> +...            self.variable += 1
> >> +...            return "payload: @{@}, ip: @{:#x@}".format(self.variable, ip)
> 
> Eli> This line is too long for @smallexample, it will cause overful hbox in the
> Eli> printed version of the manual.
> 
> Are you sure? I can't find any overfull hbox message for this line in the output
> of 'make pdf' or the resulting gdb.log. When I shorten the line significantly
> and diff the output of 'make pdf' (and gdb.log) with the long version,
> I see no real difference. There are only underful messages for python.texi for me.

In general, any line longer than about 66 characters in @example and
76 in @smallexample are too long, AFAIR.