From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id EF1483890417
 for <gdb-patches@sourceware.org>; Thu, 18 Jun 2020 17:54:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org EF1483890417
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=gnu.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=eliz@gnu.org
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44901)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <eliz@gnu.org>)
 id 1jlykc-0001zA-NF; Thu, 18 Jun 2020 13:54:58 -0400
Received: from [176.228.60.248] (port=2821 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <eliz@gnu.org>)
 id 1jlykc-0000KI-6A; Thu, 18 Jun 2020 13:54:58 -0400
Date: Thu, 18 Jun 2020 20:54:44 +0300
Message-Id: <83k104z2cb.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Pedro Alves <palves@redhat.com>
Cc: tom@tromey.com, gdb-patches@sourceware.org, tromey@adacore.com
In-Reply-To: <ce74fefb-eabe-eda3-9b57-07d4963c87be@redhat.com> (message from
 Pedro Alves on Thu, 18 Jun 2020 18:32:42 +0100)
Subject: Re: [PATCH 2/3] Consistently use BFD's time
References: <20200114210956.25115-1-tromey@adacore.com>
 <20200114210956.25115-3-tromey@adacore.com> <83wo9s4sac.fsf@gnu.org>
 <87k1044g1x.fsf@tromey.com> <83r1ucza8u.fsf@gnu.org>
 <87wo442wjq.fsf@tromey.com> <83o8pgz3lv.fsf@gnu.org>
 <ce74fefb-eabe-eda3-9b57-07d4963c87be@redhat.com>
X-Spam-Status: No, score=-5.0 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <http://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <http://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 18 Jun 2020 17:55:01 -0000

> Cc: gdb-patches@sourceware.org, tromey@adacore.com
> From: Pedro Alves <palves@redhat.com>
> Date: Thu, 18 Jun 2020 18:32:42 +0100
> 
> >> 2. Use --avoid=stat --avoid=fstat.  So far this seems like the best
> >>    approach.  Pedro pointed out that this means we won't get any gnulib
> >>    fixes for other bugs in this area.  However, given gdb's relatively
> >>    minimal needs from stat, and given the fact that gnulib is
> >>    introducing other bugs, this seems like an acceptable tradeoff to me.
> > 
> > If that works, I think it's an okay solution.
> 
> I disagree.  It's not only GDB's stat usage that counts, it's the
> other gnulib modules that depend on the stat module fixes too.  Also,
> that approach disables the stat module for all systems, not just
> mingw.  I think it's just bad policy to disable a module like that.

What would you suggest instead?