From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102737 invoked by alias); 18 Apr 2019 12:51:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 102624 invoked by uid 89); 18 Apr 2019 12:51:17 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=shorter X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 12:51:15 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59428) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hH6VU-0003JZ-QT; Thu, 18 Apr 2019 08:51:12 -0400 Received: from [176.228.60.248] (port=4492 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1hH6VU-0000I0-5k; Thu, 18 Apr 2019 08:51:12 -0400 Date: Thu, 18 Apr 2019 12:51:00 -0000 Message-Id: <83k1freatx.fsf@gnu.org> From: Eli Zaretskii To: Jan Vrany CC: gdb-patches@sourceware.org In-reply-to: <20190418115847.19854-3-jan.vrany@fit.cvut.cz> (message from Jan Vrany on Thu, 18 Apr 2019 12:58:47 +0100) Subject: Re: [PATCH v4 2/2] MI: Add new command -complete References: <20190128124101.26243-1-jan.vrany@fit.cvut.cz> <20190418115847.19854-3-jan.vrany@fit.cvut.cz> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-04/txt/msg00315.txt.bz2 > From: Jan Vrany > Cc: Jan Vrany > Date: Thu, 18 Apr 2019 12:58:47 +0100 > > +The result consists of two one or two fields: ^^^^^^^^^^^^^^ A typo. > +@smallexample > +(gdb) > +-complete br > +^done,completion="break",matches=["break","break-range"],max_completions_reached="0" > +(gdb) > +-complete "b ma" > +^done,completion="b ma",matches=["b madvise","b main"],max_completions_reached="0" > +(gdb) > +-complete "b push_b" > +^done,completion="b push_back(", > + matches=["b A::push_back(void*)", > + "b std::string::push_back(char)", > + "b std::vector >::push_back(int&&)"], > + max_completions_reached="0" The "done" lines are too long, please break them into lines shorter than 70 characters. Otherwise, the documentation parts are OK. Thanks.