From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92665 invoked by alias); 28 Nov 2018 07:02:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 92635 invoked by uid 89); 28 Nov 2018 07:02:12 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:1074 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 28 Nov 2018 07:02:09 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gRtrJ-00071C-2y for gdb-patches@sourceware.org; Wed, 28 Nov 2018 02:02:08 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52981) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gRtrI-00070w-WC; Wed, 28 Nov 2018 02:02:05 -0500 Received: from [176.228.60.248] (port=2978 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gRtrI-0002er-Fn; Wed, 28 Nov 2018 02:02:04 -0500 Date: Wed, 28 Nov 2018 07:02:00 -0000 Message-Id: <83k1kxfzwo.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: gdb-patches@sourceware.org In-reply-to: <20181128001435.12703-1-tom@tromey.com> (message from Tom Tromey on Tue, 27 Nov 2018 17:14:19 -0700) Subject: Re: [PATCH 00/16] Add styling to the gdb CLI and TUI References: <20181128001435.12703-1-tom@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg00512.txt.bz2 > From: Tom Tromey > Date: Tue, 27 Nov 2018 17:14:19 -0700 > > This series doesn't support the Windows console. I don't know > anything about it. So, it defaults to disabling styling on Windows > hosts. This could be fixed by doing something like what the TUI does: > filter escape sequences from the output and apply them by some other > means. Will the Windows TUI build support styling out of the box? It uses ncurses. And I don't think I understand what you mean by "filter escape sequences from the output". Where (on what level) would such filter be installed, given that output is written directly to the console? I see that you introduced the emit_style_escape function that switches styles. What I don't think I understand is whether it will work to have a Windows implementation of that that calls a function which causes the text output after that to use given colors? It seems it will, because the code calls emit_style_escape before and after each string, but I cannot be sure. Thanks.