From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1702 invoked by alias); 29 Aug 2018 16:19:04 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 1171 invoked by uid 89); 29 Aug 2018 16:19:03 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=HContent-type:utf-8, U*gdb-patches, gdb-patches@sourceware.org, gdbpatchessourcewareorg X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 16:19:01 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fv3BI-0000U7-IU for gdb-patches@sourceware.org; Wed, 29 Aug 2018 12:18:59 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:51656) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fv3BI-0000U3-E2; Wed, 29 Aug 2018 12:18:56 -0400 Received: from [176.228.60.248] (port=2016 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fv3BI-0001eX-0l; Wed, 29 Aug 2018 12:18:56 -0400 Date: Wed, 29 Aug 2018 16:19:00 -0000 Message-Id: <83k1o92ljo.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: sizious@gmail.com, palves@redhat.com, gdb-patches@sourceware.org In-reply-to: (message from Simon Marchi on Wed, 29 Aug 2018 11:50:43 -0400) Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> <83wosa2yos.fsf@gnu.org> <56153263-c5e6-45ce-8629-c5a77cf17f5b@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00741.txt.bz2 > Date: Wed, 29 Aug 2018 11:50:43 -0400 > From: Simon Marchi > Cc: Eli Zaretskii , Pedro Alves , > gdb-patches@sourceware.org > > > ser-mingw.c:368:30: error: 'ERROR_IO_PENDING' was not declared in this > > scope > >        if (GetLastError () != ERROR_IO_PENDING > >                               ^~~~~~~~~~~~~~~~ > > make[2]: *** [ser-mingw.o] Error 1 > > If this constant is supposed to be defined in the win32 API but is > missing with mingw, could it be that it's more of a mingw bug, and it > should be fixed there? It is not a MinGW bug: this constant is defined in winerror.h that comes with MinGW's w32api package. The problem seems to be that winerror.h somehow doesn't get included in that source file, neither directly nor indirectly. I will try to look into it some time soon.