From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 116264 invoked by alias); 27 May 2018 15:54:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 115398 invoked by uid 89); 27 May 2018 15:54:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=H*r:2001, Hx-languages-length:1648 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 27 May 2018 15:54:52 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fMy0N-00055Z-AY for gdb-patches@sourceware.org; Sun, 27 May 2018 11:54:50 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:50973) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fMy0N-00055V-6M; Sun, 27 May 2018 11:54:47 -0400 Received: from [176.228.60.248] (port=2419 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1fMy0M-0005NB-Kk; Sun, 27 May 2018 11:54:47 -0400 Date: Sun, 27 May 2018 21:01:00 -0000 Message-Id: <83k1rp856r.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey CC: palves@redhat.com, gdb-patches@sourceware.org In-reply-to: <87in79znmh.fsf@tromey.com> (message from Tom Tromey on Sat, 26 May 2018 23:14:14 -0600) Subject: Re: [RFA v2] Add "continue" response to pager Reply-to: Eli Zaretskii References: <20180425145200.27734-1-tom@tromey.com> <941985b1-5166-44ab-72fe-b0f62d411e2e@redhat.com> <87d0y44iyi.fsf@tromey.com> <6b0962b4-1867-0003-6310-e874ff1df2f3@redhat.com> <87in79znmh.fsf@tromey.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-05/txt/msg00720.txt.bz2 > From: Tom Tromey > Cc: Tom Tromey , gdb-patches@sourceware.org > Date: Sat, 26 May 2018 23:14:14 -0600 > > commit ccd0b974d93f5a87b33fdfb38eea7ed12b00fca0 > Author: Tom Tromey > Date: Wed Apr 25 08:52:00 2018 -0600 > > Add "continue" response to pager > > This adds a "continue" response to the pager. If the user types "c" > in response to the pager prompt, pagination will be disabled for the > duration of one command -- but re-enabled afterward. This is handy if > you type a command that produces a lot of output, and you don't want > to baby-sit it by typing "return" each time the prompt comes up. > > I think this version addresses all review comments from versions 1-3. > > Tested by the buildbot. > > ChangeLog > 2018-05-26 Tom Tromey > > PR cli/12326: > * NEWS: Add entry about pager. > * utils.c (pagination_disabled_for_command): New global. > (prompt_for_continue): Allow "c" response to prompt. > (reinitialize_more_filter): Clear > pagination_disabled_for_command. > (fputs_maybe_filtered): Check pagination_disabled_for_command. > > doc/ChangeLog > 2018-05-26 Tom Tromey > > PR cli/12326: > * gdb.texinfo (Screen Size): Document "c" response to pagination > prompt. > > testsuite/ChangeLog > 2018-05-26 Tom Tromey > > PR cli/12326: > * gdb.cp/static-print-quit.exp: Update. > * lib/gdb.exp (pagination_prompt): Update. > * gdb.base/page.exp: Use pagination_prompt. Add new tests. > * gdb.python/python.exp: Use pagination_prompt. Thanks, this is okay for the documentation parts.