From: Eli Zaretskii <eliz@gnu.org>
To: Nathan Froyd <froydnj@codesourcery.com>
Cc: brobecker@adacore.com, j0.kim@samsung.com, gdb-patches@sourceware.org
Subject: Re: [patch]change dwarf2_start_subfile() to adapt inappropriate dir name
Date: Mon, 15 Nov 2010 18:34:00 -0000 [thread overview]
Message-ID: <83k4kecu8a.fsf@gnu.org> (raw)
In-Reply-To: <20101115180513.GJ8544@codesourcery.com>
> Date: Mon, 15 Nov 2010 10:05:14 -0800
> From: Nathan Froyd <froydnj@codesourcery.com>
> Cc: JuYoung Kim <j0.kim@samsung.com>, Eli Zaretskii <eliz@gnu.org>,
> "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
>
> + if (dirname[dir_len-1] == SLASH_STRING[0])
Sorry, but comparing with SLASH_STRING[0] is as bad as comparing with
a literal '/' or '\\'. The issue here is that DOS/Windows filesystems
can use both / and \, and even mix them freely in the same file name.
IS_DIR_SEPARATOR takes this into account, while comparing against a
single character will miss the other alternative.
SLASH_STRING is for _constructing_ file names (with `concat' or
equivalent code), not for taking file names apart or examining them.
next prev parent reply other threads:[~2010-11-15 18:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-15 6:25 JuYoung Kim
2010-11-15 16:58 ` Joel Brobecker
2010-11-15 18:05 ` Nathan Froyd
2010-11-15 18:34 ` Eli Zaretskii [this message]
2010-11-23 20:47 ` Tom Tromey
-- strict thread matches above, loose matches on Subject: below --
2010-11-15 1:21 JuYoung Kim
2010-11-15 4:09 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83k4kecu8a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=brobecker@adacore.com \
--cc=froydnj@codesourcery.com \
--cc=gdb-patches@sourceware.org \
--cc=j0.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).