From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 460F93858C2A for ; Tue, 12 Dec 2023 14:51:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 460F93858C2A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 460F93858C2A Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702392698; cv=none; b=w8y52lyPsQXZWoWiTZclQl60Z2huFU8rl0olbr7qaseeylutlfTqaJqXYIXGBujfuXclDcdeZNMzHA7HyF+2/q7hNK8onjtzcy6zwaLwFAGgJu7I2eMwCociuhdzV5FoxMlg7VQx1bPAt4xxLSSsLNnhbTqwyUj5eJo0iyqo1c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702392698; c=relaxed/simple; bh=xqSM3G6Cq89/DllRTDFTLinuM+VnMn8HEL2bZ7eu3pw=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=gXCR31BNvIU5wqBjIzU35ypmi+DegqepizN/WscAmVnD7n1n/MSYJl6ZdyHpoS2lID3rPQ9/k5MMTGibjY2BmuPETeqep2W4JNxQof7X+OJhmbkWZBmczQNsT3+qff6OtK+cS3ci9rcEJuVszJQoDvHIjeWvADQpijmopqKRnNA= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rD46i-0006uu-Kd; Tue, 12 Dec 2023 09:51:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3nQb9BRqntBNhiTmGrKtcXgdl1bf1ZF/RoB0fyJyYmk=; b=hYrq2JtH1BT+ NPTMIL6/JfoSzwfBAj4k54THU1MA3hw1whzaIFLy1cN8iWQyMe3TT/2WM0CUfCudpCMD6dQLeMJwP 8K+233H8FYfaI3XSsAQ0f2TffAXIIf1ivKAQQo/iHbmfZyyqCm80EIn2JzRZNVju+yfY55pFe8ntO UXSVimboEPm8ID4GjglxG0EXIHxNWvKScwMEuE7g9rm2bNf9gG9awuzNxLy7FfKzrxS8k8zpgadnI ihl0xRiFkResogatFwG0SgQgJkeWzWK/6kO/8g3fRuuLUdIr9hc5RUotGP7etEam9yAeMAWWAnbhg 8JVFE3ol9ORGAKuZ+cGG7A==; Date: Tue, 12 Dec 2023 16:51:04 +0200 Message-Id: <83le9ztqxz.fsf@gnu.org> From: Eli Zaretskii To: Tom Tromey Cc: gdb-patches@sourceware.org In-Reply-To: <20231212143357.1314799-1-tromey@adacore.com> (message from Tom Tromey on Tue, 12 Dec 2023 07:33:57 -0700) Subject: Re: [PATCH] Add 'program' to DAP 'attach' request References: <20231212143357.1314799-1-tromey@adacore.com> X-Spam-Status: No, score=0.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Tom Tromey > Cc: Tom Tromey > Date: Tue, 12 Dec 2023 07:33:57 -0700 > > In many cases, it's not possible for gdb to discover the executable > when a DAP 'attach' request is used. This patch lets the IDE supply > this information. > --- > gdb/NEWS | 2 ++ > gdb/doc/gdb.texinfo | 11 ++++++++++- > gdb/python/lib/gdb/dap/launch.py | 25 +++++++++++++++++++++---- > gdb/testsuite/gdb.dap/attach.exp | 2 +- > gdb/testsuite/lib/dap-support.exp | 11 ++++++++--- > 5 files changed, 42 insertions(+), 9 deletions(-) The documentation parts are OK, thanks. Reviewed-By: Eli Zaretskii