From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 290CA3858D35 for ; Tue, 4 Jul 2023 12:44:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 290CA3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGfOe-00062K-0w; Tue, 04 Jul 2023 08:44:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=HKMetuLHkDuPV+f/PVvOxwwjUgYYRCHOw+J3t/hel+Q=; b=pmihuEUeap5l wXZlOoNiVHjVmO8l6FRAs9BftHWczaFaqpu0Wg2wk+4x12qR2Ly24mL8vrU615I6hIyKY74OrUoQQ flZGgJlGMlAM+GEMe6vBdXlW1sUs33cBoREVdkJ81S7nYuYi4bq1lEeue3sTXaCf44gdIlTfXhJ/P 2HXdWxiOiFDeWL0YE0Xb8B20os4eMuxofgd+9y3JWPymir0Oetp/Ofj0kzeRwR8oYvotqJxWPENL3 sG4ShGEtyoZCJVD2BJXYrI1Vc0MWSgQPO5mg9ppjgVBcEgOkLqZ3HxsHZ4jQwbtFVopbKfBiH2PD+ cLhGVoXOjlUEVWLI9toWlA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qGfOd-0004R5-HY; Tue, 04 Jul 2023 08:44:43 -0400 Date: Tue, 04 Jul 2023 15:45:22 +0300 Message-Id: <83lefvlual.fsf@gnu.org> From: Eli Zaretskii To: Felix Willgerodt Cc: gdb-patches@sourceware.org, markus.t.metzger@intel.com, simark@simark.ca In-Reply-To: <20230704123600.5944-3-felix.willgerodt@intel.com> (message from Felix Willgerodt via Gdb-patches on Tue, 4 Jul 2023 14:35:52 +0200) Subject: Re: [PATCH v9 02/10] btrace: Enable auxiliary instructions in record instruction-history. References: <20230704123600.5944-1-felix.willgerodt@intel.com> <20230704123600.5944-3-felix.willgerodt@intel.com> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_BARRACUDACENTRAL,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > Cc: Felix Willgerodt > Date: Tue, 4 Jul 2023 14:35:52 +0200 > From: Felix Willgerodt via Gdb-patches > > Print the auxiliary data when a btrace_insn of type BTRACE_INSN_AUX > is encountered in the instruction-history. Printing is active by default, > it can be silenced with the /a modifier. > > This patch is in preparation for the new ptwrite feature, which is based on > auxiliary instructions. > --- > gdb/disasm-flags.h | 1 + > gdb/doc/gdb.texinfo | 3 +++ > gdb/record-btrace.c | 14 ++++++++++++++ > gdb/record.c | 5 +++++ > 4 files changed, 23 insertions(+) The gdb.texinfo part is OK, thanks. Reviewed-By: Eli Zaretskii