From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id BA0253857BBB
 for <gdb-patches@sourceware.org>; Wed, 25 May 2022 13:32:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BA0253857BBB
Received: from fencepost.gnu.org ([2001:470:142:3::e]:33050)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ntr81-0001XX-5p; Wed, 25 May 2022 09:32:45 -0400
Received: from [87.69.77.57] (port=2185 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1ntr80-0005Ny-ME; Wed, 25 May 2022 09:32:44 -0400
Date: Wed, 25 May 2022 16:32:36 +0300
Message-Id: <83leup4u17.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrew Burgess <aburgess@redhat.com>
Cc: gdb-patches@sourceware.org, andrew.burgess@embecosm.com
In-Reply-To: <c72a634495059aa9e61f0bd7c628288942dbc714.1653475113.git.aburgess@redhat.com>
 (message from Andrew Burgess via Gdb-patches on Wed, 25 May 2022
 11:49:53 +0100)
Subject: Re: [PATCHv6 4/6] gdb/python: implement the print_insn extension
 language hook
References: <cover.1651857000.git.aburgess@redhat.com>
 <cover.1653475113.git.aburgess@redhat.com>
 <c72a634495059aa9e61f0bd7c628288942dbc714.1653475113.git.aburgess@redhat.com>
X-Spam-Status: No, score=1.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Wed, 25 May 2022 13:32:46 -0000

> Date: Wed, 25 May 2022 11:49:53 +0100
> From: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Andrew Burgess <andrew.burgess@embecosm.com>
> 
>  gdb/Makefile.in                        |    1 +
>  gdb/NEWS                               |   34 +
>  gdb/data-directory/Makefile.in         |    1 +
>  gdb/doc/gdb.texinfo                    |   45 +
>  gdb/doc/python.texi                    |  328 +++++++
>  gdb/python/lib/gdb/disassembler.py     |  178 ++++
>  gdb/python/py-disasm.c                 | 1090 ++++++++++++++++++++++++
>  gdb/python/python-internal.h           |   23 +
>  gdb/python/python.c                    |    3 +-
>  gdb/testsuite/gdb.python/py-disasm.c   |   25 +
>  gdb/testsuite/gdb.python/py-disasm.exp |  209 +++++
>  gdb/testsuite/gdb.python/py-disasm.py  |  712 ++++++++++++++++
>  12 files changed, 2648 insertions(+), 1 deletion(-)
>  create mode 100644 gdb/python/lib/gdb/disassembler.py
>  create mode 100644 gdb/python/py-disasm.c
>  create mode 100644 gdb/testsuite/gdb.python/py-disasm.c
>  create mode 100644 gdb/testsuite/gdb.python/py-disasm.exp
>  create mode 100644 gdb/testsuite/gdb.python/py-disasm.py

Thanks, the documentation parts are OK.  (I reviewed only the parts
that you said where modified since v5.)