From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 99F483858C2C for ; Fri, 22 Apr 2022 13:34:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99F483858C2C Received: from fencepost.gnu.org ([2001:470:142:3::e]:56476) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhtQ0-0001t7-Io; Fri, 22 Apr 2022 09:34:23 -0400 Received: from [87.69.77.57] (port=1677 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhtPN-00038t-OC; Fri, 22 Apr 2022 09:33:35 -0400 Date: Fri, 22 Apr 2022 16:33:11 +0300 Message-Id: <83levxp7jc.fsf@gnu.org> From: Eli Zaretskii To: Luis Machado Cc: gdb-patches@sourceware.org In-Reply-To: <20220422132715.22723-1-luis.machado@arm.com> (message from Luis Machado via Gdb-patches on Fri, 22 Apr 2022 14:27:15 +0100) Subject: Re: [PATCH 1/2] [AArch64] MTE corefile support References: <20220331140343.9047-1-luis.machado@arm.com> <20220422132715.22723-1-luis.machado@arm.com> X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Apr 2022 13:34:25 -0000 > Date: Fri, 22 Apr 2022 14:27:15 +0100 > From: Luis Machado via Gdb-patches > > diff --git a/gdb/NEWS b/gdb/NEWS > index 760cb2b7abc..d6818d54972 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -3,6 +3,16 @@ > > *** Changes since GDB 12 > > +* GDB now supports dumping memory tag data for AArch64 MTE. It also supports > + reading memory tag data for AArch64 MTE from core files generated by > + the gcore command or the Linux kernel. > + > + When a process uses memory-mapped pages protected by memory tags (for > + example, AArch64 MTE), this additional information will be recorded in > + the core file in the event of a crash or if GDB generates a core file > + from the current process state. GDB will show this additional information > + automatically, or through one of the memory-tag subcommands. > + This part is OK. > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index c1e9b09e833..d9021f1c56d 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -25545,6 +25545,24 @@ options that can be controlled at runtime and emulates the @code{prctl} > option @code{PR_SET_TAGGED_ADDR_CTRL}. For further information, see the > documentation in the Linux kernel. > > +@value{GDBN} supports dumping memory tag data to core files through the > +@command{gcore} command and reading memory tag data from core files generated > +by the @command{gcore} command or the Linux kernel. > + > +When a process uses memory-mapped pages protected by memory tags (for > +example, AArch64 MTE), this additional information will be recorded in > +the core file in the event of a crash or if @value{GDB} generates a core file > +from the current process state. > + > +The memory tag data will be used so developers can display the memory > +tags from a particular memory region (using the @samp{m} modifier to the > +@command{x} command, using the @command{print} command or using the various > +@command{memory-tag} subcommands. Please add here cross-references to where the respective commands are described. The documentation parts are okay with that nit fixed. Thanks.