From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id B02353858D1E for ; Wed, 20 Apr 2022 17:30:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B02353858D1E Received: from fencepost.gnu.org ([2001:470:142:3::e]:40864) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhEAK-0003k9-Nt; Wed, 20 Apr 2022 13:30:56 -0400 Received: from [87.69.77.57] (port=2891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhEAK-0007eQ-7m; Wed, 20 Apr 2022 13:30:56 -0400 Date: Wed, 20 Apr 2022 20:30:48 +0300 Message-Id: <83levzslvb.fsf@gnu.org> From: Eli Zaretskii To: Joel Brobecker Cc: aburgess@redhat.com, gdb-patches@sourceware.org, brobecker@adacore.com, pedro@palves.net In-Reply-To: (message from Joel Brobecker on Wed, 20 Apr 2022 10:11:36 -0700) Subject: Re: GDB 12.0.90 available for testing References: <1113857996.1779276.1648999598328@mail.yahoo.com> <83czhyfa8i.fsf@gnu.org> <83wng1b161.fsf@gnu.org> <83tuaz6e3x.fsf@gnu.org> <874k2prr1c.fsf@redhat.com> <838rs1ujzd.fsf@gnu.org> X-Spam-Status: No, score=1.7 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 X-Spam-Level: * X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Apr 2022 17:30:59 -0000 > Date: Wed, 20 Apr 2022 10:11:36 -0700 > From: Joel Brobecker > Cc: Andrew Burgess , gdb-patches@sourceware.org, > brobecker@adacore.com, pedro@palves.net > > Hi Eli, > > > > How does the patch below look? This moves the setbuf call into a new > > > function, and includes the comment from gdb_readline_no_editing_callback. > > > > Thanks. However, the patch that I tested only used the ISATTY test in > > ui::ui, not in read_command. Not sure if that matters. > > Would you mind testing this new patch to see if it still works? Andrew said it wasn't needed, and I believe him. So feel free to install that, and thanks.