* [PING][PATCH 3/7] Handle Windows drives in rbreak paths [not found] <1168563117.1598137.1591617137383.ref@mail.yahoo.com> @ 2020-06-08 11:52 ` Hannes Domani 2020-06-08 14:52 ` Eli Zaretskii 0 siblings, 1 reply; 3+ messages in thread From: Hannes Domani @ 2020-06-08 11:52 UTC (permalink / raw) To: Gdb-patches Ping. Am Montag, 25. Mai 2020, 20:57:47 MESZ hat Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> Folgendes geschrieben: > Fixes this testsuite fail on Windows: > FAIL: gdb.base/fullpath-expand.exp: rbreak XXX/fullpath-expand-func.c:func > > If the found colon is actually part of a Windows drive, look for another. > > gdb/ChangeLog: > > 2020-05-25 Hannes Domani <ssbssa@yahoo.de> > > * symtab.c (rbreak_command): Ignore Windows drive colon. > --- > gdb/symtab.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/gdb/symtab.c b/gdb/symtab.c > index dc771c5679..d399ccef9b 100644 > --- a/gdb/symtab.c > +++ b/gdb/symtab.c > @@ -5210,6 +5210,11 @@ rbreak_command (const char *regexp, int from_tty) > { > const char *colon = strchr (regexp, ':'); > > + /* Ignore the colon if it is part of a Windows drive. */ > + if (HAS_DRIVE_SPEC (regexp) > + && (regexp[2] == '/' || regexp[2] == '\\')) > + colon = strchr (STRIP_DRIVE_SPEC (regexp), ':'); > + > if (colon && *(colon + 1) != ':') > { > int colon_index; > -- > 2.26.2 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PING][PATCH 3/7] Handle Windows drives in rbreak paths 2020-06-08 11:52 ` [PING][PATCH 3/7] Handle Windows drives in rbreak paths Hannes Domani @ 2020-06-08 14:52 ` Eli Zaretskii 2020-06-14 15:40 ` Hannes Domani 0 siblings, 1 reply; 3+ messages in thread From: Eli Zaretskii @ 2020-06-08 14:52 UTC (permalink / raw) To: Hannes Domani; +Cc: gdb-patches > Date: Mon, 8 Jun 2020 11:52:17 +0000 (UTC) > From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> > > Ping. This LGTM, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PING][PATCH 3/7] Handle Windows drives in rbreak paths 2020-06-08 14:52 ` Eli Zaretskii @ 2020-06-14 15:40 ` Hannes Domani 0 siblings, 0 replies; 3+ messages in thread From: Hannes Domani @ 2020-06-14 15:40 UTC (permalink / raw) To: Gdb-patches Am Montag, 8. Juni 2020, 16:52:27 MESZ hat Eli Zaretskii <eliz@gnu.org> Folgendes geschrieben: > > Date: Mon, 8 Jun 2020 11:52:17 +0000 (UTC) > > > From: Hannes Domani via Gdb-patches <gdb-patches@sourceware.org> > > > > Ping. > > > This LGTM, thanks. Pushed, thanks. Hannes ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-06-14 15:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1168563117.1598137.1591617137383.ref@mail.yahoo.com>
2020-06-08 11:52 ` [PING][PATCH 3/7] Handle Windows drives in rbreak paths Hannes Domani
2020-06-08 14:52 ` Eli Zaretskii
2020-06-14 15:40 ` Hannes Domani
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).