From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 43862 invoked by alias); 25 Jan 2018 16:58:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 43852 invoked by uid 89); 25 Jan 2018 16:58:39 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 25 Jan 2018 16:58:38 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eekrC-0002hb-AY for gdb-patches@sourceware.org; Thu, 25 Jan 2018 11:58:37 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56097) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eekrC-0002hV-70 for gdb-patches@sourceware.org; Thu, 25 Jan 2018 11:58:34 -0500 Received: from [176.228.60.248] (port=3799 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eekrB-0004aI-Lk for gdb-patches@sourceware.org; Thu, 25 Jan 2018 11:58:34 -0500 Date: Thu, 25 Jan 2018 16:58:00 -0000 Message-Id: <83lgglnadl.fsf@gnu.org> From: Eli Zaretskii To: gdb-patches@sourceware.org In-reply-to: <83lggvupt6.fsf@gnu.org> (message from Eli Zaretskii on Thu, 18 Jan 2018 17:52:53 +0200) Subject: Re: [ANNOUNCEMENT] GDB 8.1 release branch created! Reply-to: Eli Zaretskii References: <83h8rlyakm.fsf@gnu.org> <83lggvupt6.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2018-01/txt/msg00539.txt.bz2 > Date: Thu, 18 Jan 2018 17:52:53 +0200 > From: Eli Zaretskii Ping! Ping! OK to push this? > Ping! Is it OK to install the patch proposed below? > > > Date: Tue, 16 Jan 2018 19:31:37 +0200 > > From: Eli Zaretskii > > > > g++ -x c++ -O2 -gdwarf-4 -g3 -I. -I. -I./common -I./config -DLOCALEDIR="\"d:/usr/share/locale\"" -DHAVE_CONFIG_H -I./../include/opcode -I./../opcodes/.. -I./../readline/.. -I../bfd -I./../bfd -I./../include -I../libdecnumber -I./../libdecnumber -I./gnulib/import -Ibuild-gnulib/import -DTUI=1 -Id:/usr/include -Id:/usr/include/guile/2.0 -Id:/usr/include -Id:/usr/Python26/include -Id:/usr/Python26/include -Wall -Wpointer-arith -Wno-unused -Wunused-value -Wunused-function -Wno-switch -Wno-char-subscripts -Wempty-body -Wunused-but-set-parameter -Wunused-but-set-variable -Wno-sign-compare -Wno-narrowing -Wno-error=maybe-uninitialized -Wno-format -fno-strict-aliasing -DNDEBUG -fwrapv -c -o python/py-arch.o -MT python/py-arch.o -MMD -MP -MF python/.deps/py-arch.Tpo python/py-arch.c > > In file included from d:\usr\lib\gcc\mingw32\6.3.0\include\c++\math.h:36:0, > > from build-gnulib/import/math.h:27, > > from d:/usr/Python26/include/pyport.h:235, > > from d:/usr/Python26/include/Python.h:58, > > from python/python-internal.h:94, > > from python/py-arch.c:24: > > d:\usr\lib\gcc\mingw32\6.3.0\include\c++\cmath:1157:11: error: '::hypot' has not been declared > > using ::hypot; > > ^~~~~ > > Makefile:1618: recipe for target `python/py-arch.o' failed > > > > Googling suggests the following solution; is it okay to push this > > (with the necessary logs and after doing the "paperwork" required for > > branch changes)? Or does someone have better ideas? (Does this work > > in MinGW64?) > > > > --- gdb/python/python-internal.h~0 2018-01-12 05:31:04.000000000 +0200 > > +++ gdb/python/python-internal.h 2018-01-16 08:56:10.717759900 +0200 > > @@ -85,6 +85,12 @@ > > #define HAVE_SNPRINTF 1 > > #endif > > > > +/* Another kludge to avoid compilation errors because MinGW defines > > + 'hypot' to '_hypot', but the C++ headers says "using ::hypot". */ > > +#if defined(__MINGW32__) && defined(__cplusplus) > > +# define _hypot hypot > > +#endif > > + > > /* Request clean size types from Python. */ > > #define PY_SSIZE_T_CLEAN > > > > >