From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111050 invoked by alias); 3 Oct 2017 14:50:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 111037 invoked by uid 89); 3 Oct 2017 14:50:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.1 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=passive, HContent-type:plain, Xavier, xavier X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 03 Oct 2017 14:50:40 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dzOWo-00005R-7F for gdb-patches@sourceware.org; Tue, 03 Oct 2017 10:50:39 -0400 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34083) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dzOWo-000058-3q; Tue, 03 Oct 2017 10:50:34 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2781 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dzOWn-0005Ch-G3; Tue, 03 Oct 2017 10:50:33 -0400 Date: Tue, 03 Oct 2017 14:50:00 -0000 Message-Id: <83lgks1e1h.fsf@gnu.org> From: Eli Zaretskii To: Xavier Roirand CC: gdb-patches@sourceware.org In-reply-to: (message from Xavier Roirand on Tue, 3 Oct 2017 12:26:49 +0200) Subject: Re: [RFA v3] enable/disable sub breakpoint range Reply-to: Eli Zaretskii References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00044.txt.bz2 > From: Xavier Roirand > Date: Tue, 3 Oct 2017 12:26:49 +0200 > > This patch allows enable/disable a range of breakpoint locations > using syntax: > > .- > > with inclusive last_location_number. > > For instance, if adding a breakpoint to foo() generates 5 breakpoint > locations from 1.1 to 1.5 then it's now possible to enable/disable > only location breakpoint 1.3 to location breakpoint 1.5 > (so 1.3, 1.4 and 1.5) using syntax: > > enable 1.3-5 or disable 1.3-5 What if I have, in addition to the 1.1-1.5 breakpoints also breakpoints 4, 5, and 6 -- how do I disable 1.3, 1.4, 1.5, 4, and 5? Do I have to say something like "disable 1.3-5.0"? > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -65,6 +65,11 @@ QStartupWithShell > * The "maintenance selftest" command now takes an optional argument to > filter the tests to be run. > > +* Breakpoint commands accept location ranges. > + > +The breakpoint commands ``enable'', and ``disable'' now accept a > +location range of breakpoints, e.g. ``1.3-5''. > + This part is OK. > +@code{enable} and @code{disable} commands. It's also possible to > +@code{enable} and @code{disable} range of @var{location-number} > +breakpoints using a @var{breakpoint-number} and two @var{location-number}, > +in increasing order, separated by a hyphen, like > +‘@var{breakpoint-number}.5-7’. ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This should be @kbd{@var{breakpoint-number}.@var{location-number1}-@var{location-number2}} or @kbd{@var{breakpoint-number}.5-7} (In general, if you find yourself using `..', "..", or any similar quoting in a Texinfo source, you can be sure something's wrong ;-) > +In this case, when a @var{location-number} range is given to this > +command, all breakpoints belonging to this @var{breakpoint-number} > +and inside that range are operated on. It is always best to avoid passive tense, as using that tends to produce unnecessarily complicated and cumbersome text. Suggest to reword: If you use such a range of location numbers, @value{GDBN} will act on all the breakpoints in that range. > +Note that you cannot delete the individual locations from the list, > +you can only delete the entire list of locations that belong to their > +parent breakpoint (with the @kbd{delete @var{num}} command, where > +@var{num} is the number of the parent breakpoint, 1 in the above example). > +Disabling or enabling the parent breakpoint (@pxref{Disabling}) affects > +all of the locations that belong to that breakpoint. This is just a complicated way of saying that the 'delete' command doesn't support location-ranges, right? If so, why not just say so? Thanks.