From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16331 invoked by alias); 11 Nov 2014 15:41:18 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16176 invoked by uid 89); 11 Nov 2014 15:41:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout27.012.net.il Received: from mtaout27.012.net.il (HELO mtaout27.012.net.il) (80.179.55.183) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Nov 2014 15:41:15 +0000 Received: from conversion-daemon.mtaout27.012.net.il by mtaout27.012.net.il (HyperSendmail v2007.08) id <0NEV00A00SOQQC00@mtaout27.012.net.il> for gdb-patches@sourceware.org; Tue, 11 Nov 2014 17:36:26 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout27.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEV00804SOQK420@mtaout27.012.net.il>; Tue, 11 Nov 2014 17:36:26 +0200 (IST) Date: Tue, 11 Nov 2014 15:41:00 -0000 From: Eli Zaretskii Subject: Re: RFA: info macro [-at LOCATION,] In-reply-to: <7612.1415714475@usendtaylorx2l> To: David Taylor Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83lhnhn3se.fsf@gnu.org> References: <31913.1415655693@usendtaylorx2l> <83mw7ymmdw.fsf@gnu.org> <7612.1415714475@usendtaylorx2l> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00186.txt.bz2 > cc: "gdb-patches@sourceware.org" > Date: Tue, 11 Nov 2014 09:01:15 -0500 > From: David Taylor > > > Thanks. I think this warrants a NEWS entry as well. > > Thanks. How are diffs for NEWS handled? Like any other file you modify. > For the text, how about: > > * New options > > The info macro command now takes an optional location ([-at LOCATION,]) > for determining which definition, if any, of the macro is in scope. If > left unspecified it, as before, uses the source and line associated with > the current program counter. Fine with me, thanks. > > > * gdb.texinfo: Document new -at LOCATION option of the 'info > > > macro' command. > > > > Please state the node in which the change was made (as if it were a > > function, i.e. in parentheses). > > Okay, how about: > > 2014-11-10 David Taylor > > * gdb.texinfo (Macros): Document new -at LOCATION option of > the 'info macro' command. OK. > > And second, "it is used instead of the current location" leaves too > > much unsaid. The reader will wonder why does location matter for this > > purpose. I suggest to make that explicit in the text. > > I'm not sure how to word it nor exactly what you are looking for. > How about the following for the gdb/doc/gdb.texinfo piece: Sounds good to me. > Thanks for reviewing the doc changes so quickly. Thanks for working on this in the first place.