From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-108579-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26064 invoked by alias); 19 Dec 2013 17:29:57 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 25925 invoked by uid 89); 19 Dec 2013 17:29:56 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2
X-HELO: mtaout22.012.net.il
Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Dec 2013 17:29:55 +0000
Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MY200500DVP6B00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 19 Dec 2013 19:29:52 +0200 (IST)
Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MY2003FPDXSS2S0@a-mtaout22.012.net.il>; Thu, 19 Dec 2013 19:29:52 +0200 (IST)
Date: Thu, 19 Dec 2013 17:29:00 -0000
From: Eli Zaretskii <eliz@gnu.org>
Subject: Re: [PATCH v9 12/29] record-btrace: make ranges include begin and end
In-reply-to: <1387471499-29444-13-git-send-email-markus.t.metzger@intel.com>
To: Markus Metzger <markus.t.metzger@intel.com>
Cc: jan.kratochvil@redhat.com, palves@redhat.com, gdb-patches@sourceware.org
Reply-to: Eli Zaretskii <eliz@gnu.org>
Message-id: <83lhzgbvfg.fsf@gnu.org>
References: <1387471499-29444-1-git-send-email-markus.t.metzger@intel.com> <1387471499-29444-13-git-send-email-markus.t.metzger@intel.com>
X-IsSubscribed: yes
X-SW-Source: 2013-12/txt/msg00783.txt.bz2

> From: Markus Metzger <markus.t.metzger@intel.com>
> Cc: gdb-patches@sourceware.org, Eli Zaretskii <eliz@gnu.org>
> Date: Thu, 19 Dec 2013 17:44:42 +0100
> 
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -45,6 +45,9 @@
>    The instruction range is now prefixed with 'insn'.
>    The source line range is now prefixed with 'at'.
>  
> +* The ranges given as arguments to the 'record function-call-history' and
> +  'record instruction-history' commands are now inclusive.

This part is OK.

>  @item record instruction-history @var{begin} @var{end}
>  Disassembles instructions beginning with instruction number
> -@var{begin} until instruction number @var{end}.  The instruction
> -number @var{end} is not included.
> +@var{begin} until instruction number @var{end}.
>  @end table

The previous text explicitly said the range was not inclusive, so I
suggest that we now say it _is_ inclusive.  I always ask myself this
question when I read similar descriptions that don't spell that out.

>  @item record function-call-history @var{begin} @var{end}
>  Prints functions beginning with function number @var{begin} until
> -function number @var{end}.  The function number @var{end} is not
> -included.
> +function number @var{end}.

Same here.

The documentation parts are OK with these changes.

Thanks.