From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id 007573858D33 for ; Wed, 22 Nov 2023 14:37:30 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 007573858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 007573858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700663853; cv=none; b=XTIAeIaj5AbJ5k24V97ZcMjHFxyQmwx1OEcRKgEdn1V05eUMiCNa7Fx94FrdOwxKKv0qo5a7H6ZzBGougT7KuN+DzkbMdg+PoRz7k5KgtxlxxvvJ1BTyhfgMPj7Gxgb8bQUGsNpgLvCmkACl1/N/2TkT0BRo+0I54iPW2pnHhf8= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1700663853; c=relaxed/simple; bh=4rePyHvIct9qUNUz8W+tcoDZxEmBHij5Runad/4ZWG8=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=JcpjYNNUK8ZxH4ss2gbW5RVloS4hoUoyqBdwf/95g7Naj9k8IoiHLvtZ2vGhEjKJFF0fH0oXrJMItBzOF8y76f2wkEeXwT/TnWkME2oJH8LAn2II+1RcHFJNfnUCiQe3YUtkJ/bWJYZs5wejJ+YiIr2WDGDAJ454Nn1/q8DMJpU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r5oM2-0006M8-QK; Wed, 22 Nov 2023 09:37:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=vgP1UxrulNuA/17LXQmmHuAfRBnt95wvSP/NLzaYyPQ=; b=SXLiGITaNUpU UraKIwuMyiuMLsr5q6PR51jx/zbiyPoqK8npm1TRfPMTpMXiBO/p6wzqeNGkeuKC1CsgXIW3DN4Kj kKrpNCvEN/f+/bG4kpCbf2yXrmsAnx3nhEBgjDBxSAMB27OR1Dcx+rLtFFZj5HX1TfFr5bdsxzMhg 50nMN5RXXJ7TQSlfmNZbKiiFuzEPnphX2un4p9ewCwsVq9CbKMSqnZXVuOqpqtC4ls+ogu48q3q0N /hYgNRvjRF4bucNEfMp8YZa4a9O9VB41Vb9RURGqmW5EyCGZlzH97Mpk6KT/68+8upEhesVpYuGDc fd1h401oT9hZvrAX/6JLyw==; Date: Wed, 22 Nov 2023 16:37:14 +0200 Message-Id: <83msv5hn1h.fsf@gnu.org> From: Eli Zaretskii To: Abdul Basit Ijaz Cc: gdb-patches@sourceware.org, blarsen@redhat.com, pedro@palves.net, philippe.waroquiers@skynet.be, aburgess@redhat.com, tankut.baris.aktemur@intel.com, christina.schimpe@intel.com, lsix@lancelotsix.com In-Reply-To: <20231122081301.5997-2-abdul.b.ijaz@intel.com> (message from Abdul Basit Ijaz on Wed, 22 Nov 2023 09:13:00 +0100) Subject: Re: [PATCH v6 1/2] gdb: add annotation in 'info locals' command for variables shadowing case References: <20231122081301.5997-1-abdul.b.ijaz@intel.com> <20231122081301.5997-2-abdul.b.ijaz@intel.com> X-Spam-Status: No, score=-5.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Abdul Basit Ijaz > Cc: blarsen@redhat.com, > pedro@palves.net, > philippe.waroquiers@skynet.be, > aburgess@redhat.com, > tankut.baris.aktemur@intel.com, > christina.schimpe@intel.com, > lsix@lancelotsix.com, > eliz@gnu.org, > "Ijaz, Abdul B" > Date: Wed, 22 Nov 2023 09:13:00 +0100 > > diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo > index e4c00143fd1..6efcc5a8dc9 100644 > --- a/gdb/doc/gdb.texinfo > +++ b/gdb/doc/gdb.texinfo > @@ -8833,6 +8833,21 @@ The optional flag @samp{-q}, which stands for @samp{quiet}, disables > printing header information and messages explaining why no local variables > have been printed. > > +@smallexample > +1: int x = 3; > +2: @{ > +3: int x = 4; // breakpt > +4: @} > +(gdb) info locals > +x = 4 > +x = 3 > +@end smallexample > + > +A variable is shadowed when there's another variable by the same > +name which is declared within an inner scope (decision block, > +method, or inner class). For such cases, its location for the > +outermost scope is followed by @samp{shadowed}. > + > @item info locals [-q] [-t @var{type_regexp}] [@var{regexp}] > Like @kbd{info locals}, but only print the local variables selected > with the provided regexp(s). This part of the patch is okay, thanks. Reviewed-By: Eli Zaretskii