Re: [PATCH 2/3] Add Progspace.objfile_for_address

[Eli Zaretskii <eliz@gnu.org>]

> Date: Tue, 11 Jul 2023 08:48:53 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> 
> This adds a new objfile_for_address method to gdb.Progspace.  This
> makes it easy to find the objfile for a given address.
> 
> There's a related PR; and while this change would have been sufficient
> for my original need, it's not clear to me whether I should close the
> bug.  Nevertheless I think it makes sense to at least mention it here.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=19288
> ---
>  gdb/NEWS                                  |  3 +++
>  gdb/doc/python.texi                       |  6 ++++++
>  gdb/progspace.c                           | 16 ++++++++++++++++
>  gdb/progspace.h                           |  4 ++++
>  gdb/python/py-progspace.c                 | 27 +++++++++++++++++++++++++++
>  gdb/testsuite/gdb.python/py-progspace.exp |  7 +++++++
>  6 files changed, 63 insertions(+)

Thanks.

> diff --git a/gdb/NEWS b/gdb/NEWS
> index b924834d3d7..a97b5fb9364 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -230,6 +230,9 @@ info main
>  
>    ** gdb.Value now has the 'assign' method.
>  
> +  ** gdb.Progspace now has the new method "objfile_for_address".  This
> +     returns the gdb.Objfile, if any, that covers a given address.
> +
>  *** Changes in GDB 13

This part is OK.

> diff --git a/gdb/doc/python.texi b/gdb/doc/python.texi
> index 9a342f34bf0..9bb907d1982 100644
> --- a/gdb/doc/python.texi
> +++ b/gdb/doc/python.texi
> @@ -5068,6 +5068,12 @@ Return the name of the shared library holding the given @var{address}
>  as a string, or @code{None}.
>  @end defun
>  
> +@findex Progspace.objfile_for_address
> +@defun Progspace.objfile_for_address (address)

Why did you need a @findex here?  AFAIR, @defun makes an index entry
automatically, so this will just create duplicate index entry.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>