From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] Improve MI -dprintf-insert documentation
Date: Wed, 31 May 2023 17:57:23 +0300 [thread overview]
Message-ID: <83mt1keegc.fsf@gnu.org> (raw)
In-Reply-To: <20230531143932.3487356-1-tromey@adacore.com> (message from Tom Tromey via Gdb-patches on Wed, 31 May 2023 08:39:32 -0600)
> Cc: Tom Tromey <tromey@adacore.com>
> Date: Wed, 31 May 2023 08:39:32 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
>
> I found the documentation for -dprintf-insert a bit unclear. It
> didn't mention the possibility of multiple arguments, and I also
> noticed that it implied that the format parameter is optional, which
> it is not.
>
> While looking into this I also noticed a few comments in the
> implementation that could also be improved.
>
> Then, I noticed a repeated call to strlen in a loop condition, so I
> fixed this up as well.
> ---
> gdb/doc/gdb.texinfo | 9 +++++++--
> gdb/mi/mi-cmd-break.c | 10 +++++-----
> 2 files changed, 12 insertions(+), 7 deletions(-)
OK for the documentation part, thanks.
Reviewed-By: Eli Zaretskii <eliz@gnu.org>
next prev parent reply other threads:[~2023-05-31 14:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 14:39 Tom Tromey
2023-05-31 14:57 ` Eli Zaretskii [this message]
2023-06-01 10:06 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83mt1keegc.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).