From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id A6F4C3858D20
 for <gdb-patches@sourceware.org>; Tue, 15 Mar 2022 14:32:31 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6F4C3858D20
Received: from [2001:470:142:3::e] (port=39114 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nU8Dv-0008WH-6Q; Tue, 15 Mar 2022 10:32:31 -0400
Received: from [87.69.77.57] (port=3160 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nU8Du-0002T5-Md; Tue, 15 Mar 2022 10:32:31 -0400
Date: Tue, 15 Mar 2022 16:32:22 +0200
Message-Id: <83mthri8w9.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Tom Tromey <tromey@adacore.com>
Cc: gdb-patches@sourceware.org
In-Reply-To: <20220315132500.1032991-5-tromey@adacore.com> (message from Tom
 Tromey via Gdb-patches on Tue, 15 Mar 2022 07:25:00 -0600)
Subject: Re: [PATCH 4/4] Reimplement array concatenation for Ada and D
References: <20220315132500.1032991-1-tromey@adacore.com>
 <20220315132500.1032991-5-tromey@adacore.com>
X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Tue, 15 Mar 2022 14:32:32 -0000

> Date: Tue, 15 Mar 2022 07:25:00 -0600
> From: Tom Tromey via Gdb-patches <gdb-patches@sourceware.org>
> Cc: Tom Tromey <tromey@adacore.com>
> 
> This started as a patch to implement string concatenation for Ada.
> However, while working on this, I looked at how this code could
> possibly be called.  It turns out there are only two users of
> concat_operation: Ada and D.  So, in addition to implementing this for
> Ada, this patch rewrites value_concat, removing the odd "concatenate
> or repeat" semantics, which were completely unused.  As Ada and D both
> seem to represent strings using TYPE_CODE_ARRAY, this removes the
> TYPE_CODE_STRING code from there as well.
> ---
>  gdb/ada-exp.h                          |  15 +++
>  gdb/ada-exp.y                          |   2 +-
>  gdb/ada-lang.c                         |  58 ++++++++-
>  gdb/doc/gdb.texinfo                    |   5 +-
>  gdb/testsuite/gdb.ada/widewide.exp     |  12 ++
>  gdb/testsuite/gdb.dlang/expression.exp |   4 +
>  gdb/valarith.c                         | 169 ++++++-------------------
>  7 files changed, 131 insertions(+), 134 deletions(-)

OK for the documentation part.

Thanks.