From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 1751B3858C2C
 for <gdb-patches@sourceware.org>; Thu, 10 Mar 2022 06:28:15 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 1751B3858C2C
Received: from [2001:470:142:3::e] (port=51140 helo=fencepost.gnu.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSCHV-00021Q-WF; Thu, 10 Mar 2022 01:28:14 -0500
Received: from [87.69.77.57] (port=4616 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nSCHV-0008DJ-Dj; Thu, 10 Mar 2022 01:28:13 -0500
Date: Thu, 10 Mar 2022 08:28:09 +0200
Message-Id: <83mthye2yu.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: "Maciej W. Rozycki" <macro@embecosm.com>
Cc: gdb-patches@sourceware.org, simonsobisch@web.de, tom@tromey.com,
 aburgess@redhat.com
In-Reply-To: <alpine.DEB.2.20.2203092025330.11552@tpp.orcam.me.uk>
 (macro@embecosm.com)
Subject: Re: [PATCH v4 7/8] GDB: Add a character string limiting option
References: <alpine.DEB.2.20.2203031442040.11552@tpp.orcam.me.uk>
 <alpine.DEB.2.20.2203091620080.11552@tpp.orcam.me.uk>
 <83o82eewgh.fsf@gnu.org>
 <alpine.DEB.2.20.2203092025330.11552@tpp.orcam.me.uk>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Mar 2022 06:28:16 -0000

> Date: Wed, 9 Mar 2022 20:40:20 +0000 (GMT)
> From: "Maciej W. Rozycki" <macro@embecosm.com>
> cc: gdb-patches@sourceware.org, simonsobisch@web.de, 
>     Tom Tromey <tom@tromey.com>, Andrew Burgess <aburgess@redhat.com>
> 
> > And, btw, we actually count bytes, not characters, right?  If the
> > string contains multibyte sequences, we don't count characters.  I
> > think this should be mentioned.
> 
>  We do count characters not bytes, as previously discussed; cf.: 
> <https://sourceware.org/pipermail/gdb-patches/2021-December/184466.html>. 
> Multibyte sequences comprising a single character are treated as such.  
> This change does not affect it.

OK, but I still think this should be mentioned in the manual.
Previously, the setting was for "array elements", and was not specific
to character strings (though I would think that "array elements" in
case of a 'char' strings are bytes, not multibyte character
sequences), but now we are specifically addressing character strings,
so this issue begs a question that IMO the manual should answer.

Thanks.