From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17502 invoked by alias); 25 Mar 2019 18:10:21 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 17478 invoked by uid 89); 25 Mar 2019 18:10:21 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_1,SPF_PASS autolearn=ham version=3.3.1 spammy=Too, ears, HX-Languages-Length:1334, our X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (209.51.188.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 25 Mar 2019 18:10:19 +0000 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40237) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h8U32-0005CG-PR; Mon, 25 Mar 2019 14:10:15 -0400 Received: from [176.228.60.248] (port=1097 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1h8U2z-00005V-CA; Mon, 25 Mar 2019 14:10:11 -0400 Date: Mon, 25 Mar 2019 18:10:00 -0000 Message-Id: <83mulin7ui.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org, brobecker@adacore.com In-reply-to: <9d445bd2-28dd-be84-5414-510e061e4db1@simark.ca> (message from Simon Marchi on Mon, 25 Mar 2019 13:58:20 -0400) Subject: Re: GDB version as convenience variable References: <20181128001435.12703-1-tom@tromey.com> <83k1kxfzwo.fsf@gnu.org> <8736rja4i8.fsf@tromey.com> <83r2brhw8k.fsf@gnu.org> <87h8cmh1wg.fsf@tromey.com> <83va12gz8j.fsf@gnu.org> <87mumeb935.fsf@tromey.com> <83d0n8eyzw.fsf@gnu.org> <87d0n6adk2.fsf@tromey.com> <83imwyee29.fsf@gnu.org> <87d0n67d29.fsf@tromey.com> <83imwwc7pj.fsf@gnu.org> <83k1gts5it.fsf@gnu.org> <83r2aun9mk.fsf@gnu.org> <9d445bd2-28dd-be84-5414-510e061e4db1@simark.ca> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00557.txt.bz2 > From: Simon Marchi > Date: Mon, 25 Mar 2019 13:58:20 -0400 > > > +@item $_gdb_major > > +@itemx $_gdb_minor > > +@vindex $_gdb_major@{, convenience variable} > > +@vindex $_gdb_minor@{, convenience variable} > > +The major and minor version numbers of the running @value{GDBN}. > > +Development snapshots and pretest versions have their minor version > > +incremented by one; thus, @value{GDBN} pretest 9.11.90 will produce > > +the value 12 for @code{$_gdb_minor}. These variables allow you to > > +write scripts that work with different versions of @value{GDBN} > > +without errors caused by features unavailable in some of those > > +versions. > > @end table > > I get this error when trying to "make html": > > /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11216: misplaced } > /home/smarchi/src/binutils-gdb/gdb/doc/gdb.texinfo:11217: misplaced } Thanks, fixed. Too many r's... > Is it worth having a test for that? Hmm... how would you test that? > If we check that they have the expected value, it would be something > to change when a new GDB branch is created, probably (as the master > branch will now represent the next version). Maybe our release > manager should have a say in this :). I'm all ears. > Otherwise, this LGTM. Thanks for the review.