From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21428 invoked by alias); 29 Nov 2017 03:28:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 20383 invoked by uid 89); 29 Nov 2017 03:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.6 required=5.0 tests=AWL,BAYES_00,KB_WAM_FROM_NAME_SINGLEWORD,SPF_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=Hx-languages-length:571 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Nov 2017 03:28:27 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eJt2r-00077z-Nv for gdb-patches@sourceware.org; Tue, 28 Nov 2017 22:28:25 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59699) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eJt2b-00071i-LU; Tue, 28 Nov 2017 22:28:05 -0500 Received: from [176.228.60.248] (port=3615 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eJt2b-0003nw-4j; Tue, 28 Nov 2017 22:28:05 -0500 Date: Wed, 29 Nov 2017 03:28:00 -0000 Message-Id: <83mv354vcy.fsf@gnu.org> From: Eli Zaretskii To: Sergio Durigan Junior CC: gdb-patches@sourceware.org, tom@tromey.com In-reply-to: <20171128212137.15655-1-sergiodj@redhat.com> (message from Sergio Durigan Junior on Tue, 28 Nov 2017 16:21:37 -0500) Subject: Re: [PATCH v2] Implement pahole-like 'ptype /o' option Reply-to: Eli Zaretskii References: <20171121160709.23248-1-sergiodj@redhat.com> <20171128212137.15655-1-sergiodj@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2017-11/txt/msg00752.txt.bz2 > From: Sergio Durigan Junior > Cc: Tom Tromey , > Eli Zaretskii , > Sergio Durigan Junior > Date: Tue, 28 Nov 2017 16:21:37 -0500 > > Changes from v1: > > - Address Tom's comments (the command now prints offset information > about unions, and the offset info is carried on for nested structs). > > - Address Eli's comments. > > - Extended testcase. > > - A "bit" of cleanup on 'c_type_print_base'. OK for the documentation parts. Thanks.