From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108996 invoked by alias); 16 Nov 2016 16:32:40 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 108978 invoked by uid 89); 16 Nov 2016 16:32:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_PASS autolearn=ham version=3.3.2 spammy=implemention, @GMAKE_FALSE@, @GMAKE_TRUE@, @gmake_true@ X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 16 Nov 2016 16:32:30 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c738L-0007l4-HT for gdb-patches@sourceware.org; Wed, 16 Nov 2016 11:32:28 -0500 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53949) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c738L-0007l0-EQ; Wed, 16 Nov 2016 11:32:25 -0500 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4310 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1c738K-0000pq-Oa; Wed, 16 Nov 2016 11:32:25 -0500 Date: Wed, 16 Nov 2016 16:32:00 -0000 Message-Id: <83mvgzfkrr.fsf@gnu.org> From: Eli Zaretskii To: Simon Marchi CC: gdb-patches@sourceware.org In-reply-to: <20161116160808.12830-3-simon.marchi@ericsson.com> (message from Simon Marchi on Wed, 16 Nov 2016 11:08:06 -0500) Subject: Re: [PATCH 2/4] Remove code that checks for GNU/non-GNU make Reply-to: Eli Zaretskii References: <20161116160808.12830-1-simon.marchi@ericsson.com> <20161116160808.12830-3-simon.marchi@ericsson.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00424.txt.bz2 > From: Simon Marchi > CC: Simon Marchi > Date: Wed, 16 Nov 2016 11:08:06 -0500 > > From: Simon Marchi > > Since GNU make is now required to build GDB, we can remove everything > that checks whether the current make implemention is the GNU one or > not. I simply removed the @GMAKE_TRUE@ prefixes and removed the whole > lines that were prefixed with @GMAKE_FALSE@. Since GDB is built by first running Make in sibling directories, which don't require a GNU Make yet, what does this mean in case the user runs a non-GNU Make? Will they have strange errors half way through the build? Should we detect this early on and bail out?