From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2456 invoked by alias); 11 Nov 2014 03:44:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 2442 invoked by uid 89); 11 Nov 2014 03:44:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout28.012.net.il Received: from mtaout28.012.net.il (HELO mtaout28.012.net.il) (80.179.55.184) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Nov 2014 03:44:53 +0000 Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0NEU00G00V4GVV00@mtaout28.012.net.il> for gdb-patches@sourceware.org; Tue, 11 Nov 2014 05:42:07 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NEU00C9PVM6XL50@mtaout28.012.net.il>; Tue, 11 Nov 2014 05:42:07 +0200 (IST) Date: Tue, 11 Nov 2014 03:44:00 -0000 From: Eli Zaretskii Subject: Re: RFA: info macro [-at LOCATION,] In-reply-to: <31913.1415655693@usendtaylorx2l> To: David Taylor Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83mw7ymmdw.fsf@gnu.org> References: <31913.1415655693@usendtaylorx2l> X-IsSubscribed: yes X-SW-Source: 2014-11/txt/msg00178.txt.bz2 > From: David Taylor > Date: Mon, 10 Nov 2014 16:41:33 -0500 > > A few releases ago it was possible to set a location that would be used > by 'info location' by typing something like: > > list file.c:42 > > and then do: > > info macro MACRONAME > > . Sometime between release 7.1 and 7.8 that stopped working. > > The following patch adds the option [-at LOCATION,] to 'info macro' to > enable the use of a user selected location as a documented feature. > > Three files, three change log entries: Thanks. I think this warrants a NEWS entry as well. > gdb/doc/ChangeLog: > > 2014-11-10 David Taylor > > * gdb.texinfo: Document new -at LOCATION option of the 'info > macro' command. Please state the node in which the change was made (as if it were a function, i.e. in parentheses). > -@item info macro [-a|-all] [--] @var{macro} > +@item info macro [-a|-all] [-at LOCATION,] [--] @var{macro} > Show the current definition or all definitions of the named @var{macro}, > and describe the source location or compiler command-line where that > definition was established. The optional double dash is to signify the end of > argument processing and the beginning of @var{macro} for non C-like macros where > -the macro may begin with a hyphen. > +the macro may begin with a hyphen. If the optional LOCATION is specified, > +it is used instead of the current location. First, "LOCATION" should be "@var{location}", as it is a parameter, not a literal string. And second, "it is used instead of the current location" leaves too much unsaid. The reader will wonder why does location matter for this purpose. I suggest to make that explicit in the text.