From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21173 invoked by alias); 31 Dec 2013 16:51:29 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 21163 invoked by uid 89); 31 Dec 2013 16:51:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL autolearn=no version=3.3.2 X-HELO: mtaout23.012.net.il Received: from mtaout23.012.net.il (HELO mtaout23.012.net.il) (80.179.55.175) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 31 Dec 2013 16:51:27 +0000 Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0MYO00K00JMQL900@a-mtaout23.012.net.il> for gdb-patches@sourceware.org; Tue, 31 Dec 2013 18:51:25 +0200 (IST) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MYO00K45K5OLQ20@a-mtaout23.012.net.il>; Tue, 31 Dec 2013 18:51:25 +0200 (IST) Date: Tue, 31 Dec 2013 16:51:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH v3] Events when inferior is modified In-reply-to: <52C2F2C0.3010201@gmail.com> To: Nick Bull Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83mwjhynei.fsf@gnu.org> References: <52C2F2C0.3010201@gmail.com> X-IsSubscribed: yes X-SW-Source: 2013-12/txt/msg01001.txt.bz2 > Date: Tue, 31 Dec 2013 16:37:20 +0000 > From: Nick Bull > > Ping again. At Joels suggestion I have added descriptions to the new > non-static functions - this brings the commenting in line with current > practice in Python event code, as far as I can see. Thanks. > +@item memory_changed > +Emits @code{gdb.MemoryChangedEvent} which indicates that the memory of the > +inferior has been modified by the GDB user, for instance via a command like ^^^ @value{GDBN} > +@code{set *addr = value}. The event has the following attributes: ^^^^^^^^^^^^^^^^^^^^^^^^ Suggest to put this in @w{..}, to prevent it from being broken between 2 lines. > +@defvar MemoryChangedEvent.address > +The start address of the changed region. > +@end defvar > +@defvar MemoryChangedEvent.length > +Length in bytes of the changed region. > +@end defvar Please insert an empty line between the 2 defvar's. > +@item register_changed > +Emits @code{gdb.RegisterChangedEvent} which indicates that a register in the > +inferior has been modified by the GDB user. ^^^ @value{GDBN} > +@defvar RegisterChangedEvent.frame > +A gdb.Frame object representing the frame in which the register was modified. > +@end defvar > +@defvar RegisterChangedEvent.regnum > +Denotes which register was modified. > +@end defvar An empty line between defvar's. The documentation part is OK with those changes and with suitable doc/ChangeLog entries.