From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18870 invoked by alias); 10 Aug 2010 17:07:54 -0000 Received: (qmail 18790 invoked by uid 22791); 10 Aug 2010 17:07:52 -0000 X-SWARE-Spam-Status: No, hits=-0.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_SOFTFAIL X-Spam-Check-By: sourceware.org Received: from mtaout22.012.net.il (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 10 Aug 2010 17:07:46 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L6Y00I004TXP900@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Tue, 10 Aug 2010 20:07:43 +0300 (IDT) Received: from HOME-C4E4A596F7 ([77.126.102.143]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L6Y0098B4WUFB40@a-mtaout22.012.net.il>; Tue, 10 Aug 2010 20:07:43 +0300 (IDT) Date: Tue, 10 Aug 2010 17:07:00 -0000 From: Eli Zaretskii Subject: Re: [patch] Add solib_address and decode_line Python functionality In-reply-to: <4C613540.9090009@redhat.com> To: Phil Muldoon Cc: gdb-patches@sourceware.org, tromey@redhat.com, brobecker@adacore.com Reply-to: Eli Zaretskii Message-id: <83mxsuv1jw.fsf@gnu.org> References: <4C44728D.4040408@redhat.com> <20100727162545.GF13267@adacore.com> <4C5015E2.4000205@redhat.com> <4C5C1418.7030607@redhat.com> <4C613540.9090009@redhat.com> X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2010-08/txt/msg00124.txt.bz2 > Date: Tue, 10 Aug 2010 12:17:20 +0100 > From: Phil Muldoon > CC: Tom Tromey , Joel Brobecker , > Eli Zaretskii > > > Eli> This is okay, but I would suggest to explain what happens without the > > Eli> argument first. Readers shouldn't need to read all the description of > > Eli> how the argument is parsed if they don't want to pass it. > > I've used your re-ordering in this patch, too. > > OK? I'm happy now. Thanks.