From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10]) by sourceware.org (Postfix) with ESMTPS id F15163858D33 for ; Fri, 29 Dec 2023 12:06:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org F15163858D33 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gnu.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gnu.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org F15163858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:142:3::10 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703851605; cv=none; b=TthwWbhljapX7OgQnk1u7LBpYf/UdXTK+/SaTs1wtu8brECA8gOcuvTi9a0qxPINKPgOgCsEwWJUD/Ry53rI+qVnvzHGnYyTQmnVol60tkTVFr85vr/LqalDjMAs0P56xeWKAx2ZFpxebmnFXxEGAd0fC+4VoauTxk9DOMNLRKk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703851605; c=relaxed/simple; bh=NgurjeT8x8mIUCdVDgTFpduvvTVHSwQv2Ti2CeaxXlo=; h=DKIM-Signature:Date:Message-Id:From:To:Subject; b=KK1VIQfw7nMZvPjd+GDGo2Tky2g66qYbkLdIxHZqobHpLGVPDhwBTh0aFmUNTBMFp4nTi0WYEKtom4s+W5fqNKAVoe2vdMXvVhIROxiXiz7l5dm2jR1nAODK28wdq1GY6n7D8qCYIHgJIdXwV/1wD2E3Z1xdYXfpKPDzkBuMCfk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rJBdS-0004mi-Vh; Fri, 29 Dec 2023 07:06:42 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=3WnlExLJAhTRCWZSWvZS+CqpociDEvuE8eqxlEdoFvw=; b=gLy+rw/d5Shn v8drwZ7gafT33NB4dEDHebt4C36PdQ8oWBArfCh6grqWWWArR06aAxSi9ru4vRiKhzbDbLXrh4ZyP 27MKGExu4FGJVtC5LH9P34Y99yJ1pVY9IXNFrXgfvNvXmwXMTxkMkse5xJ9c2moz3e7fx5E5z5Td2 33SCRqZRexhcKU+POQwH/KmX3h9MA5TR98vHezSA0XlrHoHrbUdeETtlOFNE+F9W90MzNkRp9l1aF lS6iNZ6FJIG3Hg/2ahvZJIILZZ/N2pUUmHeorX244YBwwfVlTm2FItLiyBoCDETtAu1VaqE2V8xgM Dz38AWbHznFZqlm8Qc2UmA==; Date: Fri, 29 Dec 2023 14:06:31 +0200 Message-Id: <83o7e95i2g.fsf@gnu.org> From: Eli Zaretskii To: Natalia Saiapova Cc: gdb-patches@sourceware.org, tankut.baris.aktemur@intel.com In-Reply-To: <20231229104202.7878-7-natalia.saiapova@intel.com> (message from Natalia Saiapova on Fri, 29 Dec 2023 10:42:02 +0000) Subject: Re: [PATCH 6/6] gdb: add eval option to lock the scheduler during infcalls. References: <20231229104202.7878-1-natalia.saiapova@intel.com> <20231229104202.7878-7-natalia.saiapova@intel.com> X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: > From: Natalia Saiapova > Cc: tankut.baris.aktemur@intel.com > Date: Fri, 29 Dec 2023 10:42:02 +0000 > > diff --git a/gdb/NEWS b/gdb/NEWS > index bdbbadacb89..532179cdca1 100644 > --- a/gdb/NEWS > +++ b/gdb/NEWS > @@ -18,16 +18,20 @@ disassemble > > * New commands > > -set scheduler-locking replay run | replay step | run | step (on|off) > -show scheduler-locking (replay run | replay step | run | step) > - Extend the scheduler locking settings with a set of set/show > +set scheduler-locking eval | replay eval | replay run | replay step | run | step (on|off) > +show scheduler-locking (eval | replay eval | replay run | replay step | run | step) > + Extend the scheduler-locking settings with a set of set/show > commands, which can be used individually to control the scheduler during > various commands. > - 'replay run' -- when on, the scheduler is locked during non-stepping > + 'eval' -- when on, the scheduler is locked during expression evaluation > + in normal mode. Doesn't this affect only expression evaluation that calls functions in the inferior? That is, commands like "print 2+2" will not be affected, right? If I'm right, this should be mentioned in the documentation. Thanks. Reviewed-By: Eli Zaretskii