Re: [PATCH] [gdb/symtab] Add set/show always-read-ctf on/off

[Eli Zaretskii <eliz@gnu.org>]

> Date: Thu, 2 Mar 2023 08:18:45 +0100
> Cc: Tom de Vries via Gdb-patches <gdb-patches@sourceware.org>
> From: Tom de Vries <tdevries@suse.de>
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index bea604d7e75..c32ff92c98a 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -68,6 +68,11 @@ maintenance info frame-unwinders
>    List the frame unwinders currently in effect, starting with the highest
>    priority.
>  
> +set always-read-ctf on|off
> +show always-read-ctf
> +  When off, CTF is only read if DWARF is not present.  When on, CTF is
> +  read regardless of whether DWARF is present.  Off by default.
> +
>  * New convenience function "$_shell", to execute a shell command and
>    return the result.  This lets you run shell commands in expressions.
>    Some examples:

This part is OK.

> diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo
> index c1ca45521ea..85fe2158ce8 100644
> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -20365,6 +20365,15 @@ location to represent a line or a statement.  The @samp{PROLOGUE-END} column
>  indicates that a given address is an adequate place to set a breakpoint at the
>  first instruction following a function prologue.
>  
> +@kindex set always-read-ctf [on|off]
> +@kindex show always-read-ctf
> +@cindex always-read-ctf

I'd add a @cindex entry that begins with CTF, something like

  @cindex CTF info, when to read

> +When off, CTF is only read if DWARF is not present.  When on, CTF is
> +read regardless of whether DWARF is present.  The default value if off.

It's probably "CTF debug info" and "DWARF debug info", right?

Thanks.

Reviewed-By: Eli Zaretskii <eliz@gnu.org>