From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [209.51.188.92])
 by sourceware.org (Postfix) with ESMTPS id 3CE4D3858438
 for <gdb-patches@sourceware.org>; Mon, 18 Jul 2022 19:14:45 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3CE4D3858438
Received: from fencepost.gnu.org ([2001:470:142:3::e]:44476)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oDWCa-0003EF-Ly; Mon, 18 Jul 2022 15:14:44 -0400
Received: from [87.69.77.57] (port=4106 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1oDWCa-0007XA-3Z; Mon, 18 Jul 2022 15:14:44 -0400
Date: Mon, 18 Jul 2022 22:14:31 +0300
Message-Id: <83o7xmnsh4.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Andrei Pikas <gdb@mail.api.win>
Cc: gdb-patches@sourceware.org, gdb@mail.api.win, aburgess@redhat.com
In-Reply-To: <20220718191118.57311-1-gdb@mail.api.win> (message from Andrei
 Pikas on Mon, 18 Jul 2022 22:11:18 +0300)
Subject: Re: [PATCH v4 (fix formatting and revert cli_colors to original
 state)]
 Add style tui-current-line command to colorize TUI current line.
References: <87r12iqyr7.fsf@redhat.com>
 <20220718191118.57311-1-gdb@mail.api.win>
X-Spam-Status: No, score=1.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Mon, 18 Jul 2022 19:14:46 -0000

> From: Andrei Pikas <gdb@mail.api.win>
> Date: Mon, 18 Jul 2022 22:11:18 +0300
> Cc: Andrei Pikas <gdb@mail.api.win>, aburgess@redhat.com
> 
> Adds the ability to customize the colors of the current line of code in TUI.
> This may be desirable when code highlighting is enabled. Because higlighted
> keywords in dark blue color are indistinguishable from a black background
> (which is the default inverse color for a white terminal).
> Here is a screenshot of old and new behavior
> https://drive.google.com/file/d/1RnrDjvdsnV8y_lrnavs6wvQ6lXbtjRup/view
> ---
>  gdb/NEWS            |  4 ++++
>  gdb/cli/cli-style.c | 14 ++++++++++++++
>  gdb/cli/cli-style.h |  3 +++
>  gdb/doc/gdb.texinfo |  3 +++
>  gdb/tui/tui-io.c    | 44 ++++++++++++++++++++++++++++++++++++++++----
>  gdb/tui/tui-win.c   |  1 +
>  6 files changed, 65 insertions(+), 4 deletions(-)

The documentation parts are unchanged since I approved them, right?

Thanks.