From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <eliz@gnu.org>
Received: from eggs.gnu.org (eggs.gnu.org [IPv6:2001:470:142:3::10])
 by sourceware.org (Postfix) with ESMTPS id 07D6E385C302
 for <gdb-patches@sourceware.org>; Sat,  4 Jun 2022 06:23:29 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 07D6E385C302
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45544)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nxNC4-0002cb-1e; Sat, 04 Jun 2022 02:23:28 -0400
Received: from [87.69.77.57] (port=4913 helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@gnu.org>)
 id 1nxNC3-0007lh-G4; Sat, 04 Jun 2022 02:23:27 -0400
Date: Sat, 04 Jun 2022 09:23:41 +0300
Message-Id: <83o7z9aqvm.fsf@gnu.org>
From: Eli Zaretskii <eliz@gnu.org>
To: Keith Seitz <keiths@redhat.com>
Cc: philippe.waroquiers@skynet.be, gdb-patches@sourceware.org
In-Reply-To: <24da89de-d36f-53c7-fe69-a8c7a1c38caf@redhat.com> (message from
 Keith Seitz via Gdb-patches on Fri, 3 Jun 2022 13:40:00 -0700)
Subject: Re: [RFA] Show locno for 'multi location' breakpoint hit msg+conv var
 $bkptno $locno.
References: <20220417155311.3487509-1-philippe.waroquiers@skynet.be>
 <874988bef430ed6e239e74a4a94eb2ad13175f4a.camel@skynet.be>
 <1001e780cc1d9f7a85923d6707bf17f063b8da90.camel@skynet.be>
 <24da89de-d36f-53c7-fe69-a8c7a1c38caf@redhat.com>
X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF,
 RCVD_IN_BARRACUDACENTRAL, SPF_HELO_PASS, SPF_PASS, TXREP,
 T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6
X-Spam-Level: *
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Sat, 04 Jun 2022 06:23:30 -0000

> Date: Fri, 3 Jun 2022 13:40:00 -0700
> From: Keith Seitz via Gdb-patches <gdb-patches@sourceware.org>
> 
> I looked up the history of this patch a bit to understand the motivation
> for querying co-workers... I see Eli commented in the original April
> discussion:
> 
> > I'm not sure everyone will want to see the likes of
> >
> >  Thread 1 "foobar" hit breakpoint 10.42, some_func () at ...
> >
> > But that's MO; I'd be interested in opinions of others.
> 
> Well, I'm not a global maintainer, but I'll chime in with my opinion,
> if everyone will permit me. [Ha! You're already reading it!]
> 
> I don't think it is a big deal to see ".42" in the output. Far more
> irritating is not knowing exactly which of the many locations it hit.
> I've always felt this was akin to ambiguous output by GDB. "You hit
> breakpoint X." Oh, wait, that's one of fifty different real breakpoints.

We show the source line where the breakpoint breaks right after this,
so at least some of the ambiguity is resolved by that.