public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: tromey@sourceware.org, gdb-patches@sourceware.org
Subject: Re: [review] Add TUI border colors
Date: Thu, 14 Nov 2019 09:59:00 -0000	[thread overview]
Message-ID: <83o8xe7p8c.fsf@gnu.org> (raw)
In-Reply-To: <gerrit.1573404038000.Id13e2af0af2a0bde61282752f2c379db3220c9fc@gnutoolchain-gerrit.osci.io>

> Date: Sun, 10 Nov 2019 11:40:39 -0500
> From: "Tom Tromey (Code Review)" <gerrit@gnutoolchain-gerrit.osci.io>
> 
> +TUI active border display styling.\n\
> +Configure TUI active border colors\n\
> +The \"tui-active-border\" style is used when GDB displays the border of a\n\
> +TUI window that does have the focus."), true);

Instead of "that does have the focus", I'd say "that has the focus".
I think the former builds on the doc string for tui-border, and is
less clear when read separately.

> +@item tui-border
> +Control the styling of the TUI border.  Note that, unlike other
> +styling options, only the color of the border can be controlled via
> +@code{set style}.  This was done for compatibility reasons, as TUI
> +controls to set the border's intensity predated the addition of
> +general styling to @value{GDBN}.  @xref{TUI Configuration}.
> +
> +@item tui-active-border
> +Control the styling of the active TUI border; that is, the TUI window
> +that has the focus.  Note that, unlike other styling options, only the
> +color of the border can be controlled via @code{set style}.  This was
> +done for compatibility reasons, as TUI controls to set the active
> +border's intensity predated the addition of general styling to
> +@value{GDBN}.  @xref{TUI Configuration}.

I'd suggest to have the note only once, for both options.

The documentation parts are OK with these nits fixed.

Thanks.

  reply	other threads:[~2019-11-14  9:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-10 16:40 Tom Tromey (Code Review)
2019-11-14  9:59 ` Eli Zaretskii [this message]
2019-11-22 23:54 ` [review v2] " Tom Tromey (Code Review)
2019-11-23  7:24   ` Eli Zaretskii
2019-12-01 18:55     ` Tom Tromey
2019-11-27  0:13 ` Andrew Burgess (Code Review)
2019-12-01 18:59   ` Tom Tromey
2019-12-01 19:04 ` [pushed] " Sourceware to Gerrit sync (Code Review)
2019-12-01 19:04 ` Sourceware to Gerrit sync (Code Review)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83o8xe7p8c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=tromey@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).