From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23532 invoked by alias); 1 Aug 2013 16:37:16 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23514 invoked by uid 89); 1 Aug 2013 16:37:16 -0000 X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_50,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RDNS_NONE,SPF_SOFTFAIL autolearn=no version=3.3.1 Received: from Unknown (HELO mtaout22.012.net.il) (80.179.55.172) by sourceware.org (qpsmtpd/0.84/v0.84-167-ge50287c) with ESMTP; Thu, 01 Aug 2013 16:37:16 +0000 Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0MQV00C0025A1T00@a-mtaout22.012.net.il> for gdb-patches@sourceware.org; Thu, 01 Aug 2013 19:37:04 +0300 (IDT) Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MQV00B1T25SSG50@a-mtaout22.012.net.il>; Thu, 01 Aug 2013 19:37:04 +0300 (IDT) Date: Thu, 01 Aug 2013 16:37:00 -0000 From: Eli Zaretskii Subject: Re: [PATCH 3/3] Set stdin/stdout/stderr to binary mode in cygwin. In-reply-to: <51FA17C3.9070307@codesourcery.com> To: Yao Qi Cc: gdb-patches@sourceware.org Reply-to: Eli Zaretskii Message-id: <83ob9hz7sw.fsf@gnu.org> References: <1375087546-22591-1-git-send-email-yao@codesourcery.com> <1375087546-22591-4-git-send-email-yao@codesourcery.com> <83r4ehxtey.fsf@gnu.org> <51FA17C3.9070307@codesourcery.com> X-SW-Source: 2013-08/txt/msg00036.txt.bz2 > Date: Thu, 1 Aug 2013 16:09:39 +0800 > From: Yao Qi > CC: > > On 07/29/2013 11:44 PM, Eli Zaretskii wrote: > >> + setmode (fileno (stdin), O_BINARY); > >> >+ setmode (fileno (stdout), O_BINARY); > >> >+ setmode (fileno (stderr), O_BINARY); > > Do you really need all 3 of the standard handles in binary mode? I > > thought the problem was only with output? > > Setting stdin in binary mode is for another purpose, should go to a > separated patch. Sorry for the confusion. Patch below is to only set > stdout and stderr in binary mode. Thanks.